Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Side by Side Diff: components/autofill/core/browser/proto/autofill_sync.proto

Issue 2598113002: [Sync] Use a proto to generate AutofillSyncStorageKey's storage keys. (Closed)
Patch Set: Rebased and updated for comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 syntax = "proto2";
6
7 option optimize_for = LITE_RUNTIME;
8
9 package autofill;
10
11 // Used to convert between autofill::AutofillKey and a std::string that can be
12 // passed to sync as storage key to uniquely identify an entity of ModelType
13 // syncer::AUTOFILL.
14 message AutofillSyncStorageKey {
15 required string name = 1;
Mathieu 2017/01/06 01:51:29 I don't particularly like "required" because I bel
skym 2017/01/06 18:29:04 I didn't realize that required was generally frown
16 required string value = 2;
17 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698