components/autofill/core/browser/proto/BUILD.gn - Issue 2598113002: [Sync] Use a proto to generate AutofillSyncStorageKey's storage keys.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/autofill/core/browser/proto/BUILD.gn

Issue 2598113002: [Sync] Use a proto to generate AutofillSyncStorageKey's storage keys. (Closed)

Patch Set: Rebased and updated for comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("//third_party/protobuf/proto_library.gni")	5 import("//third_party/protobuf/proto_library.gni")

6	6

7 proto_library("proto") {	7 proto_library("proto") {

8 sources = [	8 sources = [

	9 "autofill_sync.proto",
	Mathieu 2017/01/06 01:51:29 why not "sync.proto"? We are already in the autofi why not "sync.proto"? We are already in the autofill namespace/directory skym 2017/01/06 18:29:03 You're right, it is redundant. I actually tried to Show quoted text On 2017/01/06 01:51:29, Mathieu Perreault wrote: > why not "sync.proto"? We are already in the autofill namespace/directory You're right, it is redundant. I actually tried to do this when I started. But the include guard that is generated is solely based on the relative path passed into protoc, and I couldn't figure out an easy way to tweak that. So we conflict with the existing sync.proto file. Would be nice if it took into account the proto "package" field when constructing the guard string, oh well.
9 "server.proto",	10 "server.proto",

10 ]	11 ]

11 }	12 }

OLD	NEW