Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1607)

Unified Diff: components/search_engines/default_search_policy_handler.cc

Issue 2598033004: Remove old default search preferences. (Closed)
Patch Set: Updated histograms.xml Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/default_search_policy_handler.cc
diff --git a/components/search_engines/default_search_policy_handler.cc b/components/search_engines/default_search_policy_handler.cc
index 876827d60c055e700f9818a5a3fce2c6076de8e2..ef20e0e006034064afd108497061e4ab32eff76c 100644
--- a/components/search_engines/default_search_policy_handler.cc
+++ b/components/search_engines/default_search_policy_handler.cc
@@ -63,51 +63,6 @@ const PolicyToPreferenceMapEntry kDefaultSearchPolicyMap[] = {
{ key::kDefaultSearchProviderEnabled,
prefs::kDefaultSearchProviderEnabled,
base::Value::Type::BOOLEAN },
- { key::kDefaultSearchProviderName,
- prefs::kDefaultSearchProviderName,
- base::Value::Type::STRING },
- { key::kDefaultSearchProviderKeyword,
- prefs::kDefaultSearchProviderKeyword,
- base::Value::Type::STRING },
- { key::kDefaultSearchProviderSearchURL,
- prefs::kDefaultSearchProviderSearchURL,
- base::Value::Type::STRING },
- { key::kDefaultSearchProviderSuggestURL,
- prefs::kDefaultSearchProviderSuggestURL,
- base::Value::Type::STRING },
- { key::kDefaultSearchProviderInstantURL,
- prefs::kDefaultSearchProviderInstantURL,
- base::Value::Type::STRING },
- { key::kDefaultSearchProviderIconURL,
- prefs::kDefaultSearchProviderIconURL,
- base::Value::Type::STRING },
- { key::kDefaultSearchProviderEncodings,
- prefs::kDefaultSearchProviderEncodings,
- base::Value::Type::LIST },
- { key::kDefaultSearchProviderAlternateURLs,
- prefs::kDefaultSearchProviderAlternateURLs,
- base::Value::Type::LIST },
- { key::kDefaultSearchProviderSearchTermsReplacementKey,
- prefs::kDefaultSearchProviderSearchTermsReplacementKey,
- base::Value::Type::STRING },
- { key::kDefaultSearchProviderImageURL,
- prefs::kDefaultSearchProviderImageURL,
- base::Value::Type::STRING },
- { key::kDefaultSearchProviderNewTabURL,
- prefs::kDefaultSearchProviderNewTabURL,
- base::Value::Type::STRING },
- { key::kDefaultSearchProviderSearchURLPostParams,
- prefs::kDefaultSearchProviderSearchURLPostParams,
- base::Value::Type::STRING },
- { key::kDefaultSearchProviderSuggestURLPostParams,
- prefs::kDefaultSearchProviderSuggestURLPostParams,
- base::Value::Type::STRING },
- { key::kDefaultSearchProviderInstantURLPostParams,
- prefs::kDefaultSearchProviderInstantURLPostParams,
- base::Value::Type::STRING },
- { key::kDefaultSearchProviderImageURLPostParams,
- prefs::kDefaultSearchProviderImageURLPostParams,
- base::Value::Type::STRING },
};
// List of policy types to preference names, for policies affecting the default
@@ -147,52 +102,14 @@ const PolicyToPreferenceMapEntry kDefaultSearchPolicyDataMap[] = {
DefaultSearchManager::kImageURLPostParams, base::Value::Type::STRING},
};
-// DefaultSearchEncodingsPolicyHandler implementation --------------------------
-
-DefaultSearchEncodingsPolicyHandler::DefaultSearchEncodingsPolicyHandler()
- : TypeCheckingPolicyHandler(key::kDefaultSearchProviderEncodings,
- base::Value::Type::LIST) {}
-
-DefaultSearchEncodingsPolicyHandler::~DefaultSearchEncodingsPolicyHandler() {
-}
-
-void DefaultSearchEncodingsPolicyHandler::ApplyPolicySettings(
- const PolicyMap& policies, PrefValueMap* prefs) {
- // The DefaultSearchProviderEncodings policy has type list, but the related
- // preference has type string. Convert one into the other here, using
- // ';' as a separator.
- const base::Value* value = policies.GetValue(policy_name());
- const base::ListValue* list;
- if (!value || !value->GetAsList(&list))
- return;
-
- base::ListValue::const_iterator iter(list->begin());
- base::ListValue::const_iterator end(list->end());
- std::vector<std::string> string_parts;
- for (; iter != end; ++iter) {
- std::string s;
- if ((*iter)->GetAsString(&s)) {
- string_parts.push_back(s);
- }
- }
- std::string encodings = base::JoinString(string_parts, ";");
- prefs->SetString(prefs::kDefaultSearchProviderEncodings, encodings);
-}
-
-
// DefaultSearchPolicyHandler implementation -----------------------------------
DefaultSearchPolicyHandler::DefaultSearchPolicyHandler() {
for (size_t i = 0; i < arraysize(kDefaultSearchPolicyMap); ++i) {
const char* policy_name = kDefaultSearchPolicyMap[i].policy_name;
- if (policy_name == key::kDefaultSearchProviderEncodings) {
- handlers_.push_back(
- base::MakeUnique<DefaultSearchEncodingsPolicyHandler>());
- } else {
- handlers_.push_back(base::MakeUnique<SimplePolicyHandler>(
- policy_name, kDefaultSearchPolicyMap[i].preference_path,
- kDefaultSearchPolicyMap[i].value_type));
- }
+ handlers_.push_back(base::MakeUnique<SimplePolicyHandler>(
+ policy_name, kDefaultSearchPolicyMap[i].preference_path,
+ kDefaultSearchPolicyMap[i].value_type));
}
}

Powered by Google App Engine
This is Rietveld 408576698