Remove old default search preferences.

components/search_engines/default_search_policy_handler_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/search_engines/default_search_policy_handler.h"
 
 #include <memory>
 
 #include "base/memory/ptr_util.h"
 #include "components/policy/core/browser/configuration_policy_pref_store.h"
@@ skipping 128 matching lines @@
   policy.Set(key::kDefaultSearchProviderSearchURL, POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
              base::WrapUnique(new base::StringValue(bad_search_url)), nullptr);
   UpdateProviderPolicy(policy);
 
   const base::Value* temp = nullptr;
   EXPECT_FALSE(store_->GetValue(
       DefaultSearchManager::kDefaultSearchProviderDataPrefName, &temp));
 }
 
+// Checks that if the default search policy has invalid type for elements,
+// that no elements of the default search policy will be present in prefs.
+TEST_F(DefaultSearchPolicyHandlerTest, InvalidType) {
+  // List of policies defined in test policy.
+  const char* kPolicyNamesToCheck[] = {
+    key::kDefaultSearchProviderEnabled,
+    key::kDefaultSearchProviderName,
+    key::kDefaultSearchProviderKeyword,
+    key::kDefaultSearchProviderSearchURL,
+    key::kDefaultSearchProviderSuggestURL,
+    key::kDefaultSearchProviderIconURL,
+    key::kDefaultSearchProviderEncodings,
+    key::kDefaultSearchProviderAlternateURLs,
+    key::kDefaultSearchProviderSearchTermsReplacementKey,
+    key::kDefaultSearchProviderImageURL,
+    key::kDefaultSearchProviderNewTabURL,
+    key::kDefaultSearchProviderImageURLPostParams
+  };
+
+  PolicyMap policy;
+  BuildDefaultSearchPolicy(&policy);
+
+  for (auto policy_name : kPolicyNamesToCheck) {
+    // Check that policy can be successfully applied first.
+    UpdateProviderPolicy(policy);
+    const base::Value* temp = nullptr;
+    EXPECT_TRUE(store_->GetValue(
+        DefaultSearchManager::kDefaultSearchProviderDataPrefName, &temp));
+
+    auto old_value = base::WrapUnique(policy.GetValue(policy_name)->DeepCopy());
+    // BinaryValue is not supported in any current default search policy params.
+    // Try changing policy param to BinaryValue and check that policy becomes
+    // invalid.
+    policy.Set(policy_name, POLICY_LEVEL_MANDATORY,
+             POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,

[Peter Kasting, 2017/01/09 22:00:06]

Nit: Indentation

[Alexander Yashkin, 2017/01/10 05:01:44]

Done.

+             base::WrapUnique(new base::BinaryValue()), nullptr);
+    UpdateProviderPolicy(policy);
+
+    EXPECT_FALSE(store_->GetValue(
+        DefaultSearchManager::kDefaultSearchProviderDataPrefName, &temp)) <<
+        "Policy type check failed " << policy_name;
+    // Return old value to policy map.
+    policy.Set(policy_name, POLICY_LEVEL_MANDATORY,
+             POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,

[Peter Kasting, 2017/01/09 22:00:06]

Nit: Indentation

[Alexander Yashkin, 2017/01/10 05:01:44]

Done.

+             std::move(old_value), nullptr);
+  }
+}
+
 // Checks that for a fully defined search policy, all elements have been
 // read properly into the dictionary pref.
 TEST_F(DefaultSearchPolicyHandlerTest, FullyDefined) {
   PolicyMap policy;
   BuildDefaultSearchPolicy(&policy);
   UpdateProviderPolicy(policy);
 
   const base::Value* temp = NULL;
   const base::DictionaryValue* dictionary;
   std::string value;
@@ skipping 149 matching lines @@
       DefaultSearchManager::kDefaultSearchProviderDataPrefName, &temp));
   temp->GetAsDictionary(&dictionary);
 
   EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kURL, &value));
   EXPECT_EQ(kFileSearchURL, value);
   EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kShortName, &value));
   EXPECT_EQ("_", value);
   EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kKeyword, &value));
   EXPECT_EQ("_", value);
 }
+
 }  // namespace policy