Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 259803002: Add timestamps to CPU profile samples. (Closed)

Created:
6 years, 8 months ago by alph
Modified:
6 years, 8 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add timestamps to CPU profile samples. BUG=363976 LOG=Y R=bmeurer@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20993

Patch Set 1 #

Patch Set 2 : Fix race #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -23 lines) Patch
M include/v8-profiler.h View 1 chunk +20 lines, -13 lines 0 comments Download
M src/api.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/cpu-profiler.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M src/profile-generator.h View 4 chunks +5 lines, -2 lines 0 comments Download
M src/profile-generator.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M src/sampler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/sampler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 2 chunks +33 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
alph
Folks, could you please take a look.
6 years, 8 months ago (2014-04-25 07:32:32 UTC) #1
yurys
lgtm
6 years, 8 months ago (2014-04-25 09:17:14 UTC) #2
Benedikt Meurer
lgtm
6 years, 8 months ago (2014-04-25 10:42:43 UTC) #3
alph
The first sample is collected at the profiling start from the main thread. Made it ...
6 years, 8 months ago (2014-04-25 18:52:47 UTC) #4
alph
6 years, 8 months ago (2014-04-25 18:53:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r20993 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698