Suppress save and update bubbles when storing a PSL matched credential

components/password_manager/content/browser/credential_manager_impl_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/content/browser/credential_manager_impl.h"
 
 #include <stdint.h>
 
 #include <string>
 #include <tuple>
@@ skipping 503 matching lines @@
 
   EXPECT_TRUE(called);
 
   TestPasswordStore::PasswordMap passwords = store_->stored_passwords();
   EXPECT_EQ(1U, passwords.size());
   EXPECT_EQ(1U, passwords[form_.signon_realm].size());
   EXPECT_EQ(base::ASCIIToUTF16("Totally new password."),
             passwords[form_.signon_realm][0].password_value);
 }
 
+TEST_F(CredentialManagerImplTest,
+       CredentialManagerStorePSLMatchDoesNotTriggerBubble) {
+  autofill::PasswordForm psl_form = subdomain_form_;
+  psl_form.username_value = form_.username_value;
+  psl_form.password_value = form_.password_value;
+  store_->AddLogin(psl_form);
+
+  // Calling 'Store' with a credential that PSL matches |form_| should update
+  // the password without prompting the user.
+  CredentialInfo info(form_, CredentialType::CREDENTIAL_TYPE_PASSWORD);
+  EXPECT_CALL(*client_, PromptUserToSavePasswordPtr(_, _))
+      .Times(testing::Exactly(0));
+  EXPECT_CALL(*client_, NotifyStorePasswordCalled());
+  bool called = false;
+  CallStore(info, base::Bind(&RespondCallback, &called));
+
+  // Allow the PasswordFormManager to talk to the password store, determine
+  // that there is an existing PSL match and update the PasswordStore.
+  RunAllPendingTasks();
+
+  EXPECT_TRUE(called);
+}

[vasilii, 2016/12/22 13:24:59]

Check that the credential was actually stored and not dropped.

[jdoerrie, 2016/12/22 16:20:01]

Done.

+
+TEST_F(CredentialManagerImplTest,
+       CredentialManagerStoreNonPSLMatchWithDifferentUsernameTriggersBubble) {

[vasilii, 2016/12/22 13:24:59]

should it be CredentialManagerStorePSLMatchWithDifferentUsernameTriggersBubble

[jdoerrie, 2016/12/22 16:20:01]

Done.

+  base::string16 delta = base::ASCIIToUTF16("_totally_different");
+  autofill::PasswordForm in_valid_psl_form = subdomain_form_;

[vasilii, 2016/12/22 13:24:59]

What is 'in_'?

[jdoerrie, 2016/12/22 16:20:01]

Dropped it, meant to say invalid, but the PSL match in itself is correct.

+  in_valid_psl_form.username_value = form_.username_value + delta;
+  in_valid_psl_form.password_value = form_.password_value;
+  store_->AddLogin(in_valid_psl_form);
+
+  // Calling 'Store' with a credential that does not PSL match |form_| should
+  // prompt the user for an update.
+  CredentialInfo info(form_, CredentialType::CREDENTIAL_TYPE_PASSWORD);
+  EXPECT_CALL(*client_, PromptUserToSavePasswordPtr(_, _))
+      .Times(testing::Exactly(1));
+  EXPECT_CALL(*client_, NotifyStorePasswordCalled());
+  bool called = false;
+  CallStore(info, base::Bind(&RespondCallback, &called));
+
+  // Allow the PasswordFormManager to talk to the password store, determine
+  // the form is not a (PSL) match for an existing form, and update the

[vasilii, 2016/12/22 13:24:59]

What kind of 'update' are you expecting? i think it's a typo.

[jdoerrie, 2016/12/22 16:20:01]

Done.

+  // PasswordStore.
+  RunAllPendingTasks();
+
+  EXPECT_TRUE(called);

[vasilii, 2016/12/22 13:24:59]

Check that client_->pending_manager()->pending_credentials() has a decent
content.

[jdoerrie, 2016/12/22 16:20:01]

Done.

+}
+
+TEST_F(CredentialManagerImplTest,
+       CredentialManagerStoreNonPSLMatchWithDifferentPasswordTriggersBubble) {
+  base::string16 delta = base::ASCIIToUTF16("_totally_different");
+  autofill::PasswordForm in_valid_psl_form = subdomain_form_;
+  in_valid_psl_form.username_value = form_.username_value;
+  in_valid_psl_form.password_value = form_.password_value + delta;
+  store_->AddLogin(in_valid_psl_form);
+
+  // Calling 'Store' with a credential that does not PSL match |form_| should
+  // prompt the user for an update.
+  CredentialInfo info(form_, CredentialType::CREDENTIAL_TYPE_PASSWORD);
+  EXPECT_CALL(*client_, PromptUserToSavePasswordPtr(_, _))
+      .Times(testing::Exactly(1));
+  EXPECT_CALL(*client_, NotifyStorePasswordCalled());
+  bool called = false;
+  CallStore(info, base::Bind(&RespondCallback, &called));
+
+  // Allow the PasswordFormManager to talk to the password store, determine
+  // the form is not a (PSL) match for an existing form, and update the
+  // PasswordStore.
+  RunAllPendingTasks();
+
+  EXPECT_TRUE(called);
+}
+
 TEST_F(CredentialManagerImplTest, CredentialManagerStoreOverwriteZeroClick) {
   form_.skip_zero_click = true;
   store_->AddLogin(form_);
   RunAllPendingTasks();
 
   // Calling 'Store' with a credential that matches |form_| should update
   // the credential without prompting the user.
   CredentialInfo info(form_, CredentialType::CREDENTIAL_TYPE_PASSWORD);
   bool called = false;
   EXPECT_CALL(*client_, NotifyStorePasswordCalled());
@@ skipping 925 matching lines @@
                             _, CredentialSourceType::CREDENTIAL_SOURCE_API));
   CallStore(info, base::Bind(&RespondCallback, &called));
   // Allow the PasswordFormManager to talk to the password store
   RunAllPendingTasks();
 
   ASSERT_TRUE(client_->pending_manager());
   EXPECT_TRUE(client_->pending_manager()->IsBlacklisted());
 }
 
 }  // namespace password_manager