Suppress save and update bubbles when storing a PSL matched credential

components/password_manager/content/browser/credential_manager_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/content/browser/credential_manager_impl.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
@@ skipping 68 matching lines @@
   form_manager_ = base::MakeUnique<CredentialManagerPasswordFormManager>(
       client_, GetDriver(), *CreateObservedPasswordFormFromOrigin(origin),
       std::move(form), this, nullptr, nullptr);
 }
 
 void CredentialManagerImpl::OnProvisionalSaveComplete() {
   DCHECK(form_manager_);
   DCHECK(client_->IsSavingAndFillingEnabledForCurrentPage());
   const autofill::PasswordForm& form = form_manager_->pending_credentials();
 
+  if (form.is_public_suffix_match) {

[vasilii, 2016/12/22 13:24:59]

Use IsPendingCredentialsPublicSuffixMatch() for consistency with
PasswordManager::ShouldPromptUserToSavePassword()

[jdoerrie, 2016/12/22 16:20:01]

Done.

+    // Having a credential with a PSL match implies there is no credential with
+    // an exactly matching origin. This is because the presence of the exact

[vasilii, 2016/12/22 13:24:58]

exactly matching origin and username.

[jdoerrie, 2016/12/22 16:20:01]

Done.

+    // match would stop the PSL matches from appearing in the account chooser.

[vasilii, 2016/12/22 13:24:59]

The explanation is wrong. A site doesn't have to use the account chooser.
'store()' may be the only method called.

[jdoerrie, 2016/12/22 16:20:01]

Acknowledged.

+    // In order to avoid showing a save bubble to the user when he already chose
+    // this credential via the account chooser Save() is called directly.
+    form_manager_->Save();
+    return;
+  }
+
   if (!form.federation_origin.unique()) {
     // If this is a federated credential, check it against the federated matches
     // produced by the PasswordFormManager. If a match is found, update it and
     // return.
     for (const auto& match :
          form_manager_->form_fetcher()->GetFederatedMatches()) {
       if (match->username_value == form.username_value &&
           match->federation_origin.IsSameOriginWith(form.federation_origin)) {
         form_manager_->Update(*match);
         return;
@@ skipping 168 matching lines @@
 PasswordStore::FormDigest CredentialManagerImpl::GetSynthesizedFormForOrigin()
     const {
   PasswordStore::FormDigest digest = {
       autofill::PasswordForm::SCHEME_HTML, std::string(),
       web_contents()->GetLastCommittedURL().GetOrigin()};
   digest.signon_realm = digest.origin.spec();
   return digest;
 }
 
 }  // namespace password_manager