Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2597943002: Revert "Runtime support for Null as any in dart2js". (Closed)

Created:
4 years ago by kasperl
Modified:
4 years ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Runtime support for Null as any in dart2js". This caused failures on vm-kernel* and vm-precomp* bots. This reverts commit 0a1ed5fab488ad955ff2d6499e2ce981a3fbf854. TBR'ed. R=johnniwinther@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/64a0188ac3cd4fe511fe6abd41a7c71a836843ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -167 lines) Patch
M sdk/lib/_internal/js_runtime/lib/js_helper.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_rti.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language.status View 2 chunks +0 lines, -15 lines 0 comments Download
D tests/language/null_is_bottom_test.dart View 1 chunk +0 lines, -142 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kasperl
4 years ago (2016-12-22 08:29:12 UTC) #1
kasperl
Committed patchset #1 (id:1) manually as 64a0188ac3cd4fe511fe6abd41a7c71a836843ca (presubmit successful).
4 years ago (2016-12-22 08:29:26 UTC) #3
Johnni Winther
4 years ago (2016-12-22 09:35:24 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698