Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 259793002: Cleanup: Remove unnecessary .get() in test's scoped_ptr-s. (Closed)

Created:
6 years, 8 months ago by lazyboy
Modified:
6 years, 7 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Cleanup: Remove unnecessary .get() in test's scoped_ptr-s. BUG=None Test=None, internal test only change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266678

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_plugin/test_browser_plugin_guest.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M content/browser/browser_plugin/test_browser_plugin_guest_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
lazyboy
6 years, 8 months ago (2014-04-25 07:16:20 UTC) #1
Fady Samuel
lgtm
6 years, 7 months ago (2014-04-28 17:31:28 UTC) #2
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 7 months ago (2014-04-28 17:59:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/259793002/20001
6 years, 7 months ago (2014-04-28 18:03:09 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 18:27:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 7 months ago (2014-04-28 18:27:45 UTC) #6
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 7 months ago (2014-04-28 20:10:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/259793002/20001
6 years, 7 months ago (2014-04-28 20:11:38 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 22:38:44 UTC) #9
Message was sent while issue was closed. 
Change committed as 266678

Powered by Google App Engine
This is Rietveld 408576698