Source/core/html/canvas/CanvasRenderingContext2D.cpp - Issue 259773008: Add support for type checking of floating point arguments as [TypeChecking=Unrestricted]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/CanvasRenderingContext2D.cpp

Issue 259773008: Add support for type checking of floating point arguments as [TypeChecking=Unrestricted] (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: std::isfinite Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/methods.cpp ('K') | « Source/bindings/tests/results/V8TestObject.cpp ('k') | Source/core/html/canvas/CanvasRenderingContext2D.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/canvas/CanvasRenderingContext2D.cpp

diff --git a/Source/core/html/canvas/CanvasRenderingContext2D.cpp b/Source/core/html/canvas/CanvasRenderingContext2D.cpp

index 8fb31fa2206334a4892cae55288da7a9b2a5c53e..b79400a91044110604ab6261ca253806184f773a 100644

--- a/Source/core/html/canvas/CanvasRenderingContext2D.cpp

+++ b/Source/core/html/canvas/CanvasRenderingContext2D.cpp

@@ -1795,15 +1795,10 @@ PassRefPtrWillBeRawPtr<ImageData> CanvasRenderingContext2D::createImageData(Pass

PassRefPtrWillBeRawPtr<ImageData> CanvasRenderingContext2D::createImageData(float sw, float sh, ExceptionState& exceptionState) const

{

- if (!sw || !sh)

+ if (!sw || !sh) {

exceptionState.throwDOMException(IndexSizeError, String::format("The source %s is 0.", sw ? "height" : "width"));

- else if (!std::isfinite(sw))

- exceptionState.throwDOMException(NotSupportedError, ExceptionMessages::notAFiniteNumber(sw, "source width"));

- else if (!std::isfinite(sh))

- exceptionState.throwDOMException(NotSupportedError, ExceptionMessages::notAFiniteNumber(sh, "source height"));

- if (exceptionState.hadException())

return nullptr;

+ }

FloatSize logicalSize(fabs(sw), fabs(sh));

if (!logicalSize.isExpressibleAsIntSize())