Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 259773007: test_runner: Move WebPermissions into content namespace. (Closed)

Created:
6 years, 8 months ago by tfarina
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

test_runner: Move WebPermissions into content namespace. BUG=331299 TEST=None, no functional changes. Just build content_shell, content_unittests, content_browsertests to make it still link. TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266505

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M content/shell/renderer/test_runner/WebPermissions.h View 3 chunks +8 lines, -6 lines 1 comment Download
M content/shell/renderer/test_runner/WebPermissions.cpp View 2 chunks +3 lines, -2 lines 1 comment Download
M content/shell/renderer/test_runner/test_runner.h View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
tfarina
TBRing...
6 years, 8 months ago (2014-04-27 20:27:14 UTC) #1
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-04-27 20:27:19 UTC) #2
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 8 months ago (2014-04-27 20:27:19 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-04-27 20:27:20 UTC) #4
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 8 months ago (2014-04-27 20:27:20 UTC) #5
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 8 months ago (2014-04-27 20:27:20 UTC) #6
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-04-27 20:27:20 UTC) #7
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-04-27 20:27:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/259773007/1
6 years, 8 months ago (2014-04-27 20:28:30 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 01:43:23 UTC) #10
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
6 years, 7 months ago (2014-04-28 01:43:23 UTC) #11
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-04-28 01:44:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/259773007/1
6 years, 7 months ago (2014-04-28 01:44:36 UTC) #13
jochen (gone - plz use gerrit)
https://codereview.chromium.org/259773007/diff/1/content/shell/renderer/test_runner/WebPermissions.cpp File content/shell/renderer/test_runner/WebPermissions.cpp (right): https://codereview.chromium.org/259773007/diff/1/content/shell/renderer/test_runner/WebPermissions.cpp#newcode12 content/shell/renderer/test_runner/WebPermissions.cpp:12: using namespace WebTestRunner; please don't https://codereview.chromium.org/259773007/diff/1/content/shell/renderer/test_runner/WebPermissions.h File content/shell/renderer/test_runner/WebPermissions.h (right): ...
6 years, 7 months ago (2014-04-28 09:22:43 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 10:29:52 UTC) #15
Message was sent while issue was closed.
Change committed as 266505

Powered by Google App Engine
This is Rietveld 408576698