Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: content/browser/loader/upload_data_stream_builder_unittest.cc

Issue 259773006: Allow BlobDataHandles to be copied, and have their UUIDs read, on any thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make comments more uniform Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/fileapi/blob_storage_context_unittest.cc ('k') | webkit/browser/blob/blob_data_handle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/upload_data_stream_builder_unittest.cc
diff --git a/content/browser/loader/upload_data_stream_builder_unittest.cc b/content/browser/loader/upload_data_stream_builder_unittest.cc
index dba3dff4f0f234c4c6af59bfd984f3b075d614b5..f28d9b8c8ebf1e24c6a68841231eb8009b408c66 100644
--- a/content/browser/loader/upload_data_stream_builder_unittest.cc
+++ b/content/browser/loader/upload_data_stream_builder_unittest.cc
@@ -10,6 +10,7 @@
#include "base/files/file_path.h"
#include "base/message_loop/message_loop.h"
#include "base/message_loop/message_loop_proxy.h"
+#include "base/run_loop.h"
#include "base/time/time.h"
#include "content/common/resource_request_body.h"
#include "net/base/upload_bytes_element_reader.h"
@@ -257,6 +258,12 @@ TEST(UploadDataStreamBuilderTest, ResolveBlobAndCreateUploadDataStream) {
EXPECT_TRUE(AreElementsEqual(*upload->element_readers()[5], blob_element1));
EXPECT_TRUE(AreElementsEqual(*upload->element_readers()[6], blob_element2));
EXPECT_TRUE(AreElementsEqual(*upload->element_readers()[7], upload_element2));
+
+ // Clean up for ASAN.
+ handle1.reset();
+ handle2.reset();
michaeln 2014/05/01 18:50:48 bah... also need to reset request_body and maybe u
+ base::RunLoop run_loop;
+ run_loop.RunUntilIdle();
michaeln 2014/05/01 18:50:48 i've seen this more consisely written as... base::
}
} // namespace content
« no previous file with comments | « content/browser/fileapi/blob_storage_context_unittest.cc ('k') | webkit/browser/blob/blob_data_handle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698