Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 25977004: Should not use clipOutRoundedRect when a given rounded rect is empty. (Closed)

Created:
7 years, 2 months ago by tasak
Modified:
7 years, 2 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, Stephen Chennney, pdr., esprehn
Visibility:
Public.

Description

Should not use clipOutRoundedRect when a given rounded rect is empty. BUG=303922, 303383 TEST=fast/borders/border-radius-with-empty-inner-border.html,fast/borders/empty-border-radius.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159641

Patch Set 1 #

Patch Set 2 : Merged patch for crbug.com/303383 #

Patch Set 3 : Changed to use pixel tests. #

Patch Set 4 : #

Patch Set 5 : Patch for landing #

Messages

Total messages: 9 (0 generated)
tasak
7 years, 2 months ago (2013-10-04 08:30:48 UTC) #1
eseidel
7 years, 2 months ago (2013-10-04 13:56:19 UTC) #2
Stephen Chennney
The change seems fine, but why not produce correct references for the new tests? Are ...
7 years, 2 months ago (2013-10-04 17:47:12 UTC) #3
tasak
Thank you for reviewing. On 2013/10/04 17:47:12, Stephen Chenney wrote: > The change seems fine, ...
7 years, 2 months ago (2013-10-07 06:42:24 UTC) #4
tasak
Would you review this CL?
7 years, 2 months ago (2013-10-11 04:19:59 UTC) #5
eseidel
lgtm It seems the clip-out functiopn could also just ignore the empty rect instead of ...
7 years, 2 months ago (2013-10-11 04:51:45 UTC) #6
tasak
Thank you for reviewing. On 2013/10/11 04:51:45, eseidel wrote: > lgtm > > It seems ...
7 years, 2 months ago (2013-10-15 02:27:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/25977004/25001
7 years, 2 months ago (2013-10-15 02:28:15 UTC) #8
commit-bot: I haz the power
7 years, 2 months ago (2013-10-15 05:01:02 UTC) #9
Message was sent while issue was closed.
Change committed as 159641

Powered by Google App Engine
This is Rietveld 408576698