Issue 2597663002: Refactor *WorldBuilder.registerDynamicUse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2597663002: Refactor *WorldBuilder.registerDynamicUse (Closed)

Created:
4 years ago by Johnni Winther

Modified:
4 years ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Refactor *WorldBuilder.registerDynamicUse R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/6f4c3c569fd9ca7a81aaeeb8aa507ed1909112b6

Patch Set 1 #

Total comments: 1

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -76 lines)			Patch
	M	pkg/compiler/lib/src/universe/world_builder.dart	View		5 chunks	+32 lines, -76 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Johnni Winther

https://codereview.chromium.org/2597663002/diff/1/pkg/compiler/lib/src/universe/world_builder.dart File pkg/compiler/lib/src/universe/world_builder.dart (left): https://codereview.chromium.org/2597663002/diff/1/pkg/compiler/lib/src/universe/world_builder.dart#oldcode481 pkg/compiler/lib/src/universe/world_builder.dart:481: final Map<ClassElement, Map<ClassElement, bool>> _subtypeCoveredByCache = Only needed in ...

4 years ago (2016-12-21 14:37:20 UTC) #2

Johnni Winther

4 years ago (2016-12-22 10:50:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6f4c3c569fd9ca7a81aaeeb8aa507ed1909112b6 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages