Get rid of PageSet.FromDict from some simple benchmarks in gpu_tests/.

Get rid of PageSet.FromDict from some simple benchmarks in gpu_tests/.

BUG=239179
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267121

[tonyg, 2014-04-28 15:53:41]

tools/telemetry lgtm

https://codereview.chromium.org/259763003/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/page_set.py (right):

https://codereview.chromium.org/259763003/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/page_set.py:48: serving_dirs = [] if serving_dirs
is None else serving_dirs
Easier to read as `serving_dirs = serving_dirs or []`?

[nednguyen, 2014-04-28 16:02:08]

On 2014/04/28 15:53:41, tonyg wrote:
> tools/telemetry lgtm
> 
>
https://codereview.chromium.org/259763003/diff/1/tools/telemetry/telemetry/pa...
> File tools/telemetry/telemetry/page/page_set.py (right):
> 
>
https://codereview.chromium.org/259763003/diff/1/tools/telemetry/telemetry/pa...
> tools/telemetry/telemetry/page/page_set.py:48: serving_dirs = [] if
serving_dirs
> is None else serving_dirs
> Easier to read as `serving_dirs = serving_dirs or []`?

If serving_dirs is pass as [], this will create a extra []. So I prefer explicit
None checking.

[Ken Russell (switch to Gerrit), 2014-04-28 20:56:20]

Thanks for doing this conversion. LGTM with one issue.

https://codereview.chromium.org/259763003/diff/60001/content/test/gpu/gpu_tes...
File content/test/gpu/gpu_tests/context_lost.py (right):

https://codereview.chromium.org/259763003/diff/60001/content/test/gpu/gpu_tes...
content/test/gpu/gpu_tests/context_lost.py:97: class
WebGLContextLostFromGPUProcessExitPage(page.Page):
This will collide with https://codereview.chromium.org/251443006/ . Could you
please wait for it to land and then rebase?

[nednguyen, 2014-04-28 20:57:49]

On 2014/04/28 20:56:20, Ken Russell wrote:
> Thanks for doing this conversion. LGTM with one issue.
> 
>
https://codereview.chromium.org/259763003/diff/60001/content/test/gpu/gpu_tes...
> File content/test/gpu/gpu_tests/context_lost.py (right):
> 
>
https://codereview.chromium.org/259763003/diff/60001/content/test/gpu/gpu_tes...
> content/test/gpu/gpu_tests/context_lost.py:97: class
> WebGLContextLostFromGPUProcessExitPage(page.Page):
> This will collide with https://codereview.chromium.org/251443006/ . Could you
> please wait for it to land and then rebase?

Will do.

[nednguyen, 2014-04-29 01:39:08]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-04-29 01:39:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/259763003/60001

[commit-bot: I haz the power, 2014-04-29 02:12:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 02:12:46]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[nednguyen, 2014-04-29 04:12:48]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-04-29 04:13:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/259763003/80001

[commit-bot: I haz the power, 2014-04-29 05:20:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 05:20:49]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[nednguyen, 2014-04-29 12:55:42]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-04-29 12:55:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/259763003/80001

[commit-bot: I haz the power, 2014-04-29 13:18:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 13:18:20]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium

[tonyg, 2014-04-29 13:32:45]

On 2014/04/29 13:18:20, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   mac_chromium_rel on tryserver.chromium

This failure looks legit.

[nednguyen, 2014-04-29 14:52:51]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-04-29 14:53:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/259763003/100001

[commit-bot: I haz the power, 2014-04-29 21:01:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 21:01:23]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium

[nednguyen, 2014-04-29 21:50:36]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-04-29 21:57:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/259763003/100001

[commit-bot: I haz the power, 2014-04-30 00:33:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-30 00:33:24]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium

[Ken Russell (switch to Gerrit), 2014-04-30 00:48:49]

On 2014/04/30 00:33:24, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_chromium_chromeos_rel on tryserver.chromium

I would have suggested this is an infrastructure issue (see
http://crbug.com/368322 ), but it looks like apply_issue is part of the
bot_update step on that bot, and it looks like the patch needs to be rebased.

[nednguyen, 2014-04-30 01:38:47]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-04-30 01:41:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nednguyen@google.com/259763003/120001

[commit-bot: I haz the power, 2014-04-30 07:30:29]

Change committed as 267121