Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 259753002: net: don't save or load static pins from disk. (Closed)

Created:
6 years, 8 months ago by agl
Modified:
6 years, 7 months ago
Reviewers:
palmer, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ryan Sleevi
Visibility:
Public.

Description

net: don't save or load static pins from disk. It's unclear to me why we ever did this. Although we don't have an explanation, it could have something to do with the false-positive pinning reports. BUG=339907 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266672

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M net/http/transport_security_persister.cc View 3 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
agl
6 years, 8 months ago (2014-04-25 01:04:13 UTC) #1
palmer
LGTM
6 years, 8 months ago (2014-04-25 01:06:50 UTC) #2
Ryan Sleevi
FWIW, https://codereview.chromium.org/103803012/diff/150001/net/http/transport_security_persister.cc#newcode259 LGTM
6 years, 8 months ago (2014-04-25 01:21:17 UTC) #3
Ryan Sleevi
Also added the bug number - http://crbug.com/339907
6 years, 8 months ago (2014-04-25 01:22:14 UTC) #4
agl
The CQ bit was checked by agl@chromium.org
6 years, 7 months ago (2014-04-28 17:44:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/259753002/1
6 years, 7 months ago (2014-04-28 17:45:12 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 22:24:06 UTC) #7
Message was sent while issue was closed.
Change committed as 266672

Powered by Google App Engine
This is Rietveld 408576698