Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3430)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java

Issue 2596973002: [Android] Update CCT/Herb menu item (Closed)
Patch Set: Update based on Ted's comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java
index 206998b8a2b0d310da95f8453b1f92c2d07069a1..401c1dbe7c4ae6e0f85ff5f4d64cba0db8e26f6b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java
@@ -9,7 +9,9 @@ import android.app.NotificationManager;
import android.content.Context;
import org.chromium.base.ApplicationStatus;
+import org.chromium.base.BuildInfo;
import org.chromium.chrome.R;
+import org.chromium.chrome.browser.customtabs.CustomTabActivity;
import org.chromium.chrome.browser.offlinepages.downloads.OfflinePageDownloadBridge;
import org.chromium.chrome.browser.snackbar.Snackbar;
import org.chromium.chrome.browser.snackbar.SnackbarManager;
@@ -74,9 +76,17 @@ public class DownloadSnackbarController implements SnackbarManager.SnackbarContr
public void onDownloadSucceeded(
DownloadInfo downloadInfo, int notificationId, long downloadId, boolean canBeResolved) {
if (getSnackbarManager() == null) return;
- Snackbar snackbar = Snackbar.make(
- mContext.getString(R.string.download_succeeded_message, downloadInfo.getFileName()),
- this, Snackbar.TYPE_NOTIFICATION, Snackbar.UMA_DOWNLOAD_SUCCEEDED);
+ Snackbar snackbar;
+ if (getActivity() instanceof CustomTabActivity) {
+ String packageLabel = BuildInfo.getPackageLabel(getActivity());
+ snackbar = Snackbar.make(mContext.getString(R.string.download_succeeded_message,
+ downloadInfo.getFileName(), packageLabel),
+ this, Snackbar.TYPE_NOTIFICATION, Snackbar.UMA_DOWNLOAD_SUCCEEDED);
+ } else {
+ snackbar = Snackbar.make(mContext.getString(R.string.download_succeeded_message_default,
+ downloadInfo.getFileName()),
+ this, Snackbar.TYPE_NOTIFICATION, Snackbar.UMA_DOWNLOAD_SUCCEEDED);
+ }
// TODO(qinmin): Coalesce snackbars if multiple downloads finish at the same time.
snackbar.setDuration(SNACKBAR_DURATION_IN_MILLISECONDS).setSingleLine(false);
ActionDataInfo info = null;
@@ -111,10 +121,17 @@ public class DownloadSnackbarController implements SnackbarManager.SnackbarContr
getSnackbarManager().showSnackbar(snackbar);
}
+ private Activity getActivity() {
+ if (ApplicationStatus.hasVisibleActivities()) {
+ return ApplicationStatus.getLastTrackedFocusedActivity();
+ } else {
+ return null;
+ }
+ }
+
public SnackbarManager getSnackbarManager() {
- Activity activity = ApplicationStatus.getLastTrackedFocusedActivity();
- if (activity != null && ApplicationStatus.hasVisibleActivities()
- && activity instanceof SnackbarManager.SnackbarManageable) {
+ Activity activity = getActivity();
+ if (activity != null && activity instanceof SnackbarManager.SnackbarManageable) {
return ((SnackbarManager.SnackbarManageable) activity).getSnackbarManager();
}
return null;

Powered by Google App Engine
This is Rietveld 408576698