Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3142)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Issue 2596973002: [Android] Update CCT/Herb menu item (Closed)
Patch Set: Update based on Ted's comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
index 7c09524aace87a747fb8016bb8a80c738e844b8d..a478767f1f1657b941c098199e6dcb6d17265307 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
@@ -47,6 +47,7 @@ import org.chromium.chrome.browser.KeyboardShortcuts;
import org.chromium.chrome.browser.WarmupManager;
import org.chromium.chrome.browser.WebContentsFactory;
import org.chromium.chrome.browser.appmenu.AppMenuPropertiesDelegate;
+import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.StateChangeReason;
import org.chromium.chrome.browser.compositor.layouts.LayoutManagerDocument;
import org.chromium.chrome.browser.datausage.DataUseTabUIManager;
import org.chromium.chrome.browser.document.ChromeLauncherActivity;
@@ -841,6 +842,20 @@ public class CustomTabActivity extends ChromeActivity {
|| id == R.id.new_incognito_tab_menu_id || id == R.id.new_tab_menu_id
|| id == R.id.open_history_menu_id) {
return true;
+ } else if (id == R.id.bookmark_this_page_id) {
+ addOrEditBookmark(getActivityTab());
+ RecordUserAction.record("MobileMenuAddToBookmarks");
+ return true;
+ } else if (id == R.id.find_in_page_id) {
+ mFindToolbarManager.showToolbar();
+ if (getContextualSearchManager() != null) {
+ getContextualSearchManager().hideContextualSearch(StateChangeReason.UNKNOWN);
+ }
+ if (fromMenu) {
+ RecordUserAction.record("MobileMeanuFindInPage");
+ } else {
+ RecordUserAction.record("MobileShortcutFindInPage");
+ }
} else if (id == R.id.open_in_browser_id) {
openCurrentUrlInBrowser(false);
RecordUserAction.record("CustomTabsMenuOpenInChrome");

Powered by Google App Engine
This is Rietveld 408576698