chrome/android/java/res/menu/custom_tabs_menu.xml - Issue 2596973002: [Android] Update CCT/Herb menu item

Side by Side Diff: chrome/android/java/res/menu/custom_tabs_menu.xml

Issue 2596973002: [Android] Update CCT/Herb menu item (Closed)

Patch Set: Update based on Ted's comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <menu xmlns:android="http://schemas.android.com/apk/res/android">	6 <menu xmlns:android="http://schemas.android.com/apk/res/android">

7 <item android:id="@+id/icon_row_menu_id"	7 <item android:id="@+id/icon_row_menu_id"

8 android:title="@null"	8 android:title="@null"

9 android:orderInCategory="0" >	9 android:orderInCategory="0" >

10 <menu>	10 <menu>

11 <item android:id="@+id/forward_menu_id"	11 <item android:id="@+id/forward_menu_id"

12 android:title="@string/accessibility_menu_forward"	12 android:title="@string/accessibility_menu_forward"

13 android:icon="@drawable/btn_forward"/>	13 android:icon="@drawable/btn_forward"/>

	14 <item android:id="@+id/bookmark_this_page_id"

	15 android:title="@string/accessibility_menu_bookmark"

	16 android:icon="@drawable/btn_star"/>

	17 <item android:id="@+id/offline_page_id"

	18 android:title="@string/download_page"

	19 android:icon="@drawable/ic_get_app_white_24dp"/>

14 <item android:id="@+id/info_menu_id"	20 <item android:id="@+id/info_menu_id"

15 android:title="@string/accessibility_menu_info"	21 android:title="@string/accessibility_menu_info"

16 android:icon="@drawable/btn_info" />	22 android:icon="@drawable/btn_info" />

17 <item android:id="@+id/reload_menu_id"	23 <item android:id="@+id/reload_menu_id"

18 android:title="@string/accessibility_btn_refresh"	24 android:title="@string/accessibility_btn_refresh"

19 android:icon="@drawable/btn_reload_stop"/>	25 android:icon="@drawable/btn_reload_stop"/>

20 </menu>	26 </menu>

21 </item>	27 </item>

22 <item android:id="@+id/share_row_menu_id"	28 <item android:id="@+id/share_row_menu_id"

23 android:title="@null"	29 android:title="@null"

24 android:orderInCategory="2">	30 android:orderInCategory="2">

25 <menu>	31 <menu>

26 <item android:id="@+id/share_menu_id"	32 <item android:id="@+id/share_menu_id"

27 android:title="@string/menu_share_page"/>	33 android:title="@string/menu_share_page"/>

28 <item android:id="@+id/direct_share_menu_id"	34 <item android:id="@+id/direct_share_menu_id"

29 android:title="@null" />	35 android:title="@null" />

30 </menu>	36 </menu>

31 </item>	37 </item>

32 <!-- Title is intentionally left blank in xml and will be set in java. - ->	38 <!-- Title is intentionally left blank in xml and will be set in java. - ->

	39 <item android:id="@+id/find_in_page_id"

	40 android:title="@string/menu_find_in_page"

	41 android:orderInCategory="2" />

	42 <item android:id="@+id/add_to_homescreen_id"

	43 android:title="@string/menu_add_to_homescreen"

	44 android:orderInCategory="2" />

	45 <item android:id="@+id/request_desktop_site_id"

	46 android:title="@string/menu_request_desktop_site"

	47 android:checkable="true"

	48 android:icon="?android:attr/listChoiceIndicatorMultiple"

	49 android:orderInCategory="2" />

33 <item android:id="@+id/open_in_browser_id"	50 <item android:id="@+id/open_in_browser_id"

34 android:title=""	51 android:title=""

35 android:orderInCategory="2" />	52 android:orderInCategory="2" />

36 </menu>	53 </menu>

OLD	NEW