Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2616)

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc

Issue 2596913002: [Offline pages] Update background loader offliner to return error when (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
diff --git a/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc b/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
index 1ff5b68f48e943b2d0144c2fb722176157f234e3..7f567585ac9c9c9c572dd1a95d6943a1104a0778 100644
--- a/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
+++ b/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
@@ -220,12 +220,12 @@ TEST_F(BackgroundLoaderOfflinerTest, LoadedButSaveFails) {
SavePageRequest request(kRequestId, kHttpUrl, kClientId, creation_time,
kUserRequested);
EXPECT_TRUE(offliner()->LoadAndSave(request, callback()));
- EXPECT_TRUE(offliner()->is_loading());
CompleteLoading();
PumpLoop();
model()->CompleteSavingAsArchiveCreationFailed();
PumpLoop();
+
EXPECT_TRUE(completion_callback_called());
EXPECT_EQ(Offliner::RequestStatus::SAVE_FAILED, request_status());
EXPECT_FALSE(offliner()->is_loading());
@@ -240,11 +240,9 @@ TEST_F(BackgroundLoaderOfflinerTest, LoadAndSaveSuccess) {
CompleteLoading();
PumpLoop();
- EXPECT_FALSE(completion_callback_called());
- EXPECT_TRUE(SaveInProgress());
-
model()->CompleteSavingAsSuccess();
PumpLoop();
+
EXPECT_TRUE(completion_callback_called());
EXPECT_EQ(Offliner::RequestStatus::SAVED, request_status());
EXPECT_FALSE(offliner()->is_loading());

Powered by Google App Engine
This is Rietveld 408576698