[Offline pages] Update background loader offliner to return error when

chrome/browser/android/offline_pages/background_loader_offliner.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/background_loader_offliner.h"
 
 #include "base/sys_info.h"
 #include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h"
 #include "components/offline_pages/core/background/save_page_request.h"
 #include "components/offline_pages/core/offline_page_model.h"
@@ skipping 79 matching lines @@
   OfflinePageModel::SavePageParams params;
   params.url = web_contents->GetLastCommittedURL();
   params.client_id = request.client_id();
   params.proposed_offline_id = request.request_id();
   offline_page_model_->SavePage(
       params, std::move(archiver),
       base::Bind(&BackgroundLoaderOffliner::OnPageSaved,
                  weak_ptr_factory_.GetWeakPtr()));
 }
 
+void BackgroundLoaderOffliner::RenderProcessGone(

[Pete Williamson, 2016/12/21 20:49:28]

What would cause a call to RenderProcessGone?  I didn't see it get called
anywhere.

+    base::TerminationStatus status) {
+  SavePageRequest request(*pending_request_.get());
+  switch (status) {
+    case TERMINATION_STATUS_OOM:
+    case TERMINATION_STATUS_PROCESS_CRASHED:
+    case TERMINATION_STATUS_STILL_RUNNING:
+      completion_callback_.Run(request,
+                               Offliner::RequestStatus::LOADING_FAILED_NO_NEXT);
+      break;
+    case TERMINATION_STATUS_PROCESS_WAS_KILLED:

[dougarnett, 2016/12/22 01:37:53]

Can you share any insight on this case? Cleanly killed so try something else?

+    default:
+      completion_callback_.Run(request,
+                               Offliner::RequestStatus::LOADING_FAILED);
+  }
+  ResetState();
+}
+
+void BackgroundLoaderOffliner::WebContentsDestroyed() {
+  completion_callback_.Run(*pending_request_.get(),
+                           Offliner::RequestStatus::LOADING_FAILED);
+  ResetState();
+}
+
 void BackgroundLoaderOffliner::OnPageSaved(SavePageResult save_result,
                                            int64_t offline_id) {
   if (!pending_request_)
     return;
 
   SavePageRequest request(*pending_request_.get());
   ResetState();
 
   if (save_state_ == DELETE_AFTER_SAVE) {
     save_state_ = NONE;
@@ skipping 29 matching lines @@
       application_state ==
           base::android::APPLICATION_STATE_HAS_RUNNING_ACTIVITIES) {
     DVLOG(1) << "App became active, canceling current offlining request";
     SavePageRequest* request = pending_request_.get();
     Cancel();
     completion_callback_.Run(*request, RequestStatus::FOREGROUND_CANCELED);
   }
 }
 
 }  // namespace offline_pages