src/core/SkPicturePlayback.cpp - Issue 25968004: commit to xfermode objects being immutable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkPicturePlayback.cpp

Issue 25968004: commit to xfermode objects being immutable (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: use SK_DECLARE_STATIC_MUTEX Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkPicturePlayback.cpp

diff --git a/src/core/SkPicturePlayback.cpp b/src/core/SkPicturePlayback.cpp

index 13128aac74c0ba96871edb0e39b92530f537213b..04c90cee9277f98add60de4710d79de8babb7f96 100644

--- a/src/core/SkPicturePlayback.cpp

+++ b/src/core/SkPicturePlayback.cpp

@@ -152,11 +152,11 @@ static bool needs_deep_copy(const SkPaint& paint) {

* getTypeface();

* getAnnotation();

+ * getXfermode();

return paint.getPathEffect() ||

paint.getShader() ||

- paint.getXfermode() ||

paint.getMaskFilter() ||

paint.getColorFilter() ||

paint.getRasterizer() ||