Replace WM shadow types (on/off) and styles (small/inactive/active)

ui/wm/core/shadow_types.h

Index: ui/wm/core/shadow_types.h
diff --git a/ui/wm/core/shadow_types.h b/ui/wm/core/shadow_types.h
index 1198a43b16c72c84abd56a86d30fdf6e90e5d0b1..f335d581d1390eb38e2382715da125788c183b1e 100644
--- a/ui/wm/core/shadow_types.h
+++ b/ui/wm/core/shadow_types.h
@@ -16,18 +16,21 @@ namespace wm {
 
 // Different types of drop shadows that can be drawn under a window by the
 // shell.  Used as a value for the kShadowTypeKey property.
-enum ShadowType {
+enum class ShadowElevation {
   // Starts at 0 due to the cast in GetShadowType().
-  SHADOW_TYPE_NONE = 0,
-  SHADOW_TYPE_RECTANGULAR,
+  NONE = 0,

[sky, 2017/01/03 22:35:38]

It may be obvious to you, but I would document the value of the enum is used in
the shadow itself.

[Evan Stade, 2017/01/04 00:20:45]

Done.

+  SMALL = 6,
+  MEDIUM = 8,
+  BIG = 24,

[sky, 2017/01/03 22:35:38]

optional: I would have went with LARGE (mostly because menus are small, medium
and large), but if you prefer BIG, stick with it.

[Evan Stade, 2017/01/04 00:20:45]

I have no preference, done.

 };
 
-WM_EXPORT void SetShadowType(aura::Window* window, ShadowType shadow_type);
-WM_EXPORT ShadowType GetShadowType(aura::Window* window);
+WM_EXPORT void SetShadowElevation(aura::Window* window,
+                                  ShadowElevation shadow_type);
+WM_EXPORT ShadowElevation GetShadowElevation(aura::Window* window);
 
 // A property key describing the drop shadow that should be displayed under the
 // window.  If unset, no shadow is displayed.
-extern const aura::WindowProperty<ShadowType>* const kShadowTypeKey;
+extern const aura::WindowProperty<ShadowElevation>* const kShadowElevationKey;
 
 }  // namespace wm