ui/keyboard/content/keyboard_ui_content.cc - Issue 2596743002: Replace WM shadow types (on/off) and styles (small/inactive/active)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/keyboard/content/keyboard_ui_content.cc

Issue 2596743002: Replace WM shadow types (on/off) and styles (small/inactive/active) (Closed)

Patch Set: one more mechanical change Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/keyboard/content/keyboard_ui_content.cc

diff --git a/ui/keyboard/content/keyboard_ui_content.cc b/ui/keyboard/content/keyboard_ui_content.cc

index ae7972adaa1342eacd6d7d0310fa5ca0dedc052a..1dba63ec09b4d1ac76ca8950f4f284d99fc45492 100644

--- a/ui/keyboard/content/keyboard_ui_content.cc

+++ b/ui/keyboard/content/keyboard_ui_content.cc

@@ -26,6 +26,7 @@

#include "ui/keyboard/keyboard_switches.h"

#include "ui/keyboard/keyboard_util.h"

#include "ui/wm/core/shadow.h"

+#include "ui/wm/core/shadow_types.h"

namespace {

@@ -281,7 +282,7 @@ void KeyboardUIContent::OnWindowBoundsChanged(aura::Window* window,

const gfx::Rect& new_bounds) {

if (!shadow_) {

shadow_.reset(new wm::Shadow());

- shadow_->Init(wm::Shadow::STYLE_ACTIVE);

+ shadow_->Init(wm::ShadowElevation::LARGE);

shadow_->layer()->SetVisible(true);

DCHECK(keyboard_contents_->GetNativeView()->parent());

keyboard_contents_->GetNativeView()->parent()->layer()->Add(

« no previous file with comments | « components/exo/shell_surface_unittest.cc ('k') | ui/views/bubble/tray_bubble_view.cc » ('j') | no next file with comments »