Replace WM shadow types (on/off) and styles (small/inactive/active)

ui/views/widget/widget.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_WIDGET_WIDGET_H_
 #define UI_VIEWS_WIDGET_WIDGET_H_
 
 #include <map>
 #include <memory>
 #include <set>
@@ skipping 214 matching lines @@
     // IsTranslucentWindowOpacitySupported to determine whether they are.
     WindowOpacity opacity;
     bool accept_events;
     Activatable activatable;
     bool keep_on_top;
     bool visible_on_all_workspaces;
     // See Widget class comment above.
     Ownership ownership;
     bool mirror_origin_in_rtl;
     ShadowType shadow_type;
+    // A hint about the size of the shadow if the type is SHADOW_TYPE_DROP. May
+    // be ignored on some platforms. A value <0 indicates no preference.
+    int shadow_elevation;

[Evan Stade, 2016/12/21 16:57:57]

Do you think the type for this param should be ui::ShadowElevation?

[sky, 2017/01/03 22:35:38]

Yes. Additionally do we need both shadow_type and shadow_elevation?

[Evan Stade, 2017/01/04 00:20:45]

Done.
I believe we do because of the way ShadowType is used in MenuHost::InitMenuHost.
We want to be able to control whether there is a shadow (ignoring platform
default), but to leave the elevation as the default.

     // Specifies that the system default caption and icon should not be
     // rendered, and that the client area should be equivalent to the window
     // area. Only used on some platforms (Windows and Linux).
     bool remove_standard_frame;
     // Only used by ShellWindow on Windows. Specifies that the default icon of
     // packaged app should be the system default icon.
     bool use_system_default_icon;
     // Whether the widget should be maximized or minimized.
     ui::WindowShowState show_state;
     gfx::NativeView parent;
@@ skipping 725 matching lines @@
   bool movement_disabled_;
 
   ScopedObserver<ui::NativeTheme, ui::NativeThemeObserver> observer_manager_;
 
   DISALLOW_COPY_AND_ASSIGN(Widget);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_WIDGET_WIDGET_H_