Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: runtime/vm/object.cc

Issue 2596703003: Add workaround to turn precompilation-release builders green. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index d447c93c07974800b1b7eed09d92a695f0fbbebd..73e5fb152af98afba3397d99821f302936837b02 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -7268,10 +7268,16 @@ void SignatureData::set_signature_type(const Type& value) const {
// Keeping the parent function can unnecessarily pull more objects into a
// snapshot. Also, the parent function is meaningless once the signature type
// is canonicalized.
+
+// TODO(rmacnak): Keeping the parent function for unresolved signature types
+// is causing a tree shaking issue in AOT. Please, investigate.
+#if 0
if (value.IsResolved()) {
- set_parent_function(Function::Handle()); // TODO(rmacnak): Removing this
- // line causes a tree shaking issue in AOT. Please, investigate.
+ set_parent_function(Function::Handle());
}
+#else
+ set_parent_function(Function::Handle());
+#endif
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698