Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: net/spdy/spdy_session.h

Issue 2596703002: http2: Update priorities of pushed streams (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_session.h
diff --git a/net/spdy/spdy_session.h b/net/spdy/spdy_session.h
index 0a3e065aa1cd7d5f8e4e796b2bb099ddb16602e7..722a4a8e4aff92ca4c04027d6e7afed822b435eb 100644
--- a/net/spdy/spdy_session.h
+++ b/net/spdy/spdy_session.h
@@ -331,7 +331,11 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface,
// okay to create a new stream (in which case |spdy_stream| is
// reset). Returns an error (not ERR_IO_PENDING) otherwise, and
// resets |spdy_stream|.
+ //
+ // If a stream was found and the stream is still open, the priority
+ // of that stream is updated to match |priority|.
int GetPushStream(const GURL& url,
+ RequestPriority priority,
base::WeakPtr<SpdyStream>* spdy_stream,
const NetLogWithSource& stream_net_log);
@@ -684,7 +688,6 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface,
void TryCreatePushStream(SpdyStreamId stream_id,
SpdyStreamId associated_stream_id,
- SpdyPriority priority,
SpdyHeaderBlock headers);
// Close the stream pointed to by the given iterator. Note that that
@@ -704,13 +707,17 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface,
// Send a RST_STREAM frame with the given parameters. There should
// either be no active stream with the given ID, or that active
// stream should be closed shortly after this function is called.
- //
- // TODO(akalin): Rename this to EnqueueResetStreamFrame().
Bence 2017/01/05 17:14:46 Lol. Thank you for removing this obviously stale
void EnqueueResetStreamFrame(SpdyStreamId stream_id,
RequestPriority priority,
SpdyRstStreamStatus status,
const std::string& description);
+ // Send a PRIORITY frame with the given parameters.
+ void EnqueuePriorityFrame(SpdyStreamId stream_id,
+ SpdyStreamId dependency_id,
+ int weight,
+ bool exclusive);
+
// Calls DoReadLoop. Use this function instead of DoReadLoop when
// posting a task to pump the read loop.
void PumpReadLoop(ReadState expected_read_state, int result);

Powered by Google App Engine
This is Rietveld 408576698