Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 259663005: Use AudioProcessing::Initialize(). (Closed)

Created:
6 years, 8 months ago by ajm
Modified:
6 years, 8 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, Henrik Grunell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use AudioProcessing::Initialize(). Use this in place of the deprecated set_sample_rate_hz(). Similarly, switch sample_rate_hz() to input_sample_rate_hz(). TESTED=apprtc sounds as expected with constraints enabled/disabled. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266320

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M content/renderer/media/media_stream_audio_processor.cc View 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ajm
6 years, 8 months ago (2014-04-24 21:47:47 UTC) #1
no longer working on chromium
On 2014/04/24 21:47:47, ajm wrote: lgtm
6 years, 8 months ago (2014-04-25 09:15:14 UTC) #2
ajm
The CQ bit was checked by ajm@chromium.org
6 years, 8 months ago (2014-04-25 15:29:13 UTC) #3
ajm
The CQ bit was unchecked by ajm@chromium.org
6 years, 8 months ago (2014-04-25 21:17:54 UTC) #4
ajm
The CQ bit was checked by ajm@chromium.org
6 years, 8 months ago (2014-04-25 21:17:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajm@chromium.org/259663005/1
6 years, 8 months ago (2014-04-25 22:00:52 UTC) #6
ajm
The CQ bit was unchecked by ajm@chromium.org
6 years, 8 months ago (2014-04-26 01:36:15 UTC) #7
ajm
The CQ bit was checked by ajm@chromium.org
6 years, 8 months ago (2014-04-26 01:36:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajm@chromium.org/259663005/1
6 years, 8 months ago (2014-04-26 01:59:18 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-26 02:19:19 UTC) #10
Message was sent while issue was closed. 
Change committed as 266320

Powered by Google App Engine
This is Rietveld 408576698