gpuveto tool

gpuveto tool

This CL adds a command line tool to report the suitableForGpuRasterization status of a single skp file.

Committed: http://code.google.com/p/skia/source/detail?r=14393

[bsalomon, 2014-04-25 13:54:43]

https://codereview.chromium.org/259663004/diff/1/tools/gpuveto.cpp
File tools/gpuveto.cpp (right):

https://codereview.chromium.org/259663004/diff/1/tools/gpuveto.cpp#newcode59
tools/gpuveto.cpp:59: return recorded->suitableForGpuRasterization(NULL) ?
kSuitable : kUnsuitable;
Should the tool really return an error code rather than something pipeable
(stdout)? I imagine most of our scripts use the convention that the tool failed
on a non-zero return. I could be off here, though.

[robertphillips, 2014-04-25 16:20:21]

Adding Ravi to see if he has an opinion about the return code.

[rmistry, 2014-04-25 16:22:19]

https://codereview.chromium.org/259663004/diff/1/tools/gpuveto.cpp
File tools/gpuveto.cpp (right):

https://codereview.chromium.org/259663004/diff/1/tools/gpuveto.cpp#newcode59
tools/gpuveto.cpp:59: return recorded->suitableForGpuRasterization(NULL) ?
kSuitable : kUnsuitable;
On 2014/04/25 13:54:43, bsalomon wrote:
> Should the tool really return an error code rather than something pipeable
> (stdout)? I imagine most of our scripts use the convention that the tool
failed
> on a non-zero return. I could be off here, though.

Yes lets please return an error code.

[bsalomon, 2014-04-25 16:42:18]

On 2014/04/25 16:22:19, rmistry wrote:
> https://codereview.chromium.org/259663004/diff/1/tools/gpuveto.cpp
> File tools/gpuveto.cpp (right):
> 
> https://codereview.chromium.org/259663004/diff/1/tools/gpuveto.cpp#newcode59
> tools/gpuveto.cpp:59: return recorded->suitableForGpuRasterization(NULL) ?
> kSuitable : kUnsuitable;
> On 2014/04/25 13:54:43, bsalomon wrote:
> > Should the tool really return an error code rather than something pipeable
> > (stdout)? I imagine most of our scripts use the convention that the tool
> failed
> > on a non-zero return. I could be off here, though.
> 
> Yes lets please return an error code.

sgtm lgtm

[robertphillips, 2014-04-25 17:08:26]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-04-25 17:09:05]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/robertphillips@google.com/259663004/5...

[bsalomon, 2014-04-25 19:41:30]

https://codereview.chromium.org/259663004/diff/50001/tools/gpuveto.cpp
File tools/gpuveto.cpp (right):

https://codereview.chromium.org/259663004/diff/50001/tools/gpuveto.cpp#newcode61
tools/gpuveto.cpp:61: if (recorded->suitableForGpuRasterization(NULL)) {
don't we need to pass a grcontext? I guess the current impl doesn't use it...

[robertphillips, 2014-04-25 21:05:07]

https://codereview.chromium.org/259663004/diff/50001/tools/gpuveto.cpp
File tools/gpuveto.cpp (right):

https://codereview.chromium.org/259663004/diff/50001/tools/gpuveto.cpp#newcode61
tools/gpuveto.cpp:61: if (recorded->suitableForGpuRasterization(NULL)) {
Right - this is just the first pass. We will also need to add a config parameter
to this tool.

[commit-bot: I haz the power, 2014-04-28 13:19:37]

Change committed as 14393