Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: content/browser/dom_storage/dom_storage_context_wrapper.cc

Issue 2596603002: Make LevelDBObserver an associated interface to LevelDBWrapper. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/dom_storage/dom_storage_context_wrapper.h ('k') | content/browser/leveldb_wrapper_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/dom_storage/dom_storage_context_wrapper.cc
diff --git a/content/browser/dom_storage/dom_storage_context_wrapper.cc b/content/browser/dom_storage/dom_storage_context_wrapper.cc
index 1978dcc9da0d343f0aae7f32fb41c45b8eb405bc..56e9fb1006bc1b2747b273e1af9b15d8a8b4a0f4 100644
--- a/content/browser/dom_storage/dom_storage_context_wrapper.cc
+++ b/content/browser/dom_storage/dom_storage_context_wrapper.cc
@@ -96,7 +96,6 @@ class DOMStorageContextWrapper::MojoState {
weak_ptr_factory_(this) {}
void OpenLocalStorage(const url::Origin& origin,
- mojom::LevelDBObserverPtr observer,
mojom::LevelDBWrapperRequest request);
private:
@@ -121,7 +120,6 @@ class DOMStorageContextWrapper::MojoState {
// The (possibly delayed) implementation of OpenLocalStorage(). Can be called
// directly from that function, or through |on_database_open_callbacks_|.
void BindLocalStorage(const url::Origin& origin,
- mojom::LevelDBObserverPtr observer,
mojom::LevelDBWrapperRequest request);
service_manager::Connector* const connector_;
@@ -151,7 +149,6 @@ class DOMStorageContextWrapper::MojoState {
void DOMStorageContextWrapper::MojoState::OpenLocalStorage(
const url::Origin& origin,
- mojom::LevelDBObserverPtr observer,
mojom::LevelDBWrapperRequest request) {
// If we don't have a filesystem_connection_, we'll need to establish one.
if (connection_state_ == NO_CONNECTION) {
@@ -187,11 +184,11 @@ void DOMStorageContextWrapper::MojoState::OpenLocalStorage(
// Queue this OpenLocalStorage call for when we have a level db pointer.
on_database_opened_callbacks_.push_back(
base::Bind(&MojoState::BindLocalStorage, weak_ptr_factory_.GetWeakPtr(),
- origin, base::Passed(&observer), base::Passed(&request)));
+ origin, base::Passed(&request)));
return;
}
- BindLocalStorage(origin, std::move(observer), std::move(request));
+ BindLocalStorage(origin, std::move(request));
}
void DOMStorageContextWrapper::MojoState::OnDirectoryOpened(
@@ -236,7 +233,6 @@ void DOMStorageContextWrapper::MojoState::OnDatabaseOpened(
void DOMStorageContextWrapper::MojoState::BindLocalStorage(
const url::Origin& origin,
- mojom::LevelDBObserverPtr observer,
mojom::LevelDBWrapperRequest request) {
// Delay for a moment after a value is set in anticipation
// of other values being set, so changes are batched.
@@ -260,7 +256,6 @@ void DOMStorageContextWrapper::MojoState::BindLocalStorage(
}
found->second->Bind(std::move(request));
- found->second->AddObserver(std::move(observer));
}
DOMStorageContextWrapper::DOMStorageContextWrapper(
@@ -421,10 +416,8 @@ void DOMStorageContextWrapper::Flush() {
void DOMStorageContextWrapper::OpenLocalStorage(
const url::Origin& origin,
- mojom::LevelDBObserverPtr observer,
mojom::LevelDBWrapperRequest request) {
- mojo_state_->OpenLocalStorage(
- origin, std::move(observer), std::move(request));
+ mojo_state_->OpenLocalStorage(origin, std::move(request));
}
void DOMStorageContextWrapper::OnMemoryPressure(
« no previous file with comments | « content/browser/dom_storage/dom_storage_context_wrapper.h ('k') | content/browser/leveldb_wrapper_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698