Handle Security Key requests from outside the remoted session correctly

remoting/host/security_key/security_key_ipc_server_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/security_key/security_key_ipc_server.h"
 
 #include <memory>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 116 matching lines @@
   ASSERT_TRUE(security_key_ipc_server_->CreateChannel(
       channel_handle,
       /*request_timeout=*/base::TimeDelta::FromMilliseconds(500)));
 
   // Create a fake client and connect to the IPC server channel.
   FakeSecurityKeyIpcClient fake_ipc_client(base::Bind(
       &SecurityKeyIpcServerTest::OperationComplete, base::Unretained(this)));
   ASSERT_TRUE(fake_ipc_client.ConnectViaIpc(channel_handle));
   WaitForOperationComplete();
 
+  ASSERT_FALSE(fake_ipc_client.invalid_session_error());
+  ASSERT_TRUE(fake_ipc_client.connection_ready());
   ASSERT_TRUE(fake_ipc_client.ipc_channel_connected());
 
   // Send a request from the IPC client to the IPC server.
   std::string request_data("Blergh!");
   fake_ipc_client.SendSecurityKeyRequestViaIpc(request_data);
   WaitForOperationComplete();
 
   // Verify the request was received.
   ASSERT_EQ(kTestConnectionId, last_connection_id_received_);
   ASSERT_EQ(request_data, last_message_received_);
@@ skipping 15 matching lines @@
   ASSERT_TRUE(security_key_ipc_server_->CreateChannel(
       channel_handle,
       /*request_timeout=*/base::TimeDelta::FromMilliseconds(500)));
 
   // Create a fake client and connect to the IPC server channel.
   FakeSecurityKeyIpcClient fake_ipc_client(base::Bind(
       &SecurityKeyIpcServerTest::OperationComplete, base::Unretained(this)));
   ASSERT_TRUE(fake_ipc_client.ConnectViaIpc(channel_handle));
   WaitForOperationComplete();
 
+  ASSERT_FALSE(fake_ipc_client.invalid_session_error());
+  ASSERT_TRUE(fake_ipc_client.connection_ready());
   ASSERT_TRUE(fake_ipc_client.ipc_channel_connected());
 
   // Send a request from the IPC client to the IPC server.
   std::string request_data(kLargeMessageSizeBytes, 'Y');
   fake_ipc_client.SendSecurityKeyRequestViaIpc(request_data);
   WaitForOperationComplete();
 
   // Verify the request was received.
   ASSERT_EQ(kTestConnectionId, last_connection_id_received_);
   ASSERT_EQ(request_data, last_message_received_);
@@ skipping 15 matching lines @@
   ASSERT_TRUE(security_key_ipc_server_->CreateChannel(
       channel_handle,
       /*request_timeout=*/base::TimeDelta::FromMilliseconds(500)));
 
   // Create a fake client and connect to the IPC server channel.
   FakeSecurityKeyIpcClient fake_ipc_client(base::Bind(
       &SecurityKeyIpcServerTest::OperationComplete, base::Unretained(this)));
   ASSERT_TRUE(fake_ipc_client.ConnectViaIpc(channel_handle));
   WaitForOperationComplete();
 
+  ASSERT_FALSE(fake_ipc_client.invalid_session_error());
+  ASSERT_TRUE(fake_ipc_client.connection_ready());
   ASSERT_TRUE(fake_ipc_client.ipc_channel_connected());
 
   // Send a request from the IPC client to the IPC server.
   std::string request_data(kLargeMessageSizeBytes * 2, 'Y');
   fake_ipc_client.SendSecurityKeyRequestViaIpc(request_data);
   WaitForOperationComplete();
 
   // Verify the request was received.
   ASSERT_EQ(kTestConnectionId, last_connection_id_received_);
   ASSERT_EQ(request_data, last_message_received_);
@@ skipping 15 matching lines @@
   ASSERT_TRUE(security_key_ipc_server_->CreateChannel(
       channel_handle,
       /*request_timeout=*/base::TimeDelta::FromMilliseconds(500)));
 
   // Create a fake client and connect to the IPC server channel.
   FakeSecurityKeyIpcClient fake_ipc_client(base::Bind(
       &SecurityKeyIpcServerTest::OperationComplete, base::Unretained(this)));
   ASSERT_TRUE(fake_ipc_client.ConnectViaIpc(channel_handle));
   WaitForOperationComplete();
 
+  ASSERT_FALSE(fake_ipc_client.invalid_session_error());
+  ASSERT_TRUE(fake_ipc_client.connection_ready());
   ASSERT_TRUE(fake_ipc_client.ipc_channel_connected());
 
   // Send a request from the IPC client to the IPC server.
   std::string request_data_1("Blergh!");
   fake_ipc_client.SendSecurityKeyRequestViaIpc(request_data_1);
   WaitForOperationComplete();
 
   // Verify the request was received.
   ASSERT_EQ(kTestConnectionId, last_connection_id_received_);
   ASSERT_EQ(request_data_1, last_message_received_);
@@ skipping 74 matching lines @@
   ASSERT_TRUE(security_key_ipc_server_->CreateChannel(
       channel_handle,
       /*request_timeout=*/base::TimeDelta::FromMilliseconds(500)));
 
   // Create a fake client and connect to the IPC server channel.
   FakeSecurityKeyIpcClient fake_ipc_client(base::Bind(
       &SecurityKeyIpcServerTest::OperationComplete, base::Unretained(this)));
   ASSERT_TRUE(fake_ipc_client.ConnectViaIpc(channel_handle));
   WaitForOperationComplete();
 
+  ASSERT_FALSE(fake_ipc_client.invalid_session_error());
+  ASSERT_TRUE(fake_ipc_client.connection_ready());
   ASSERT_TRUE(fake_ipc_client.ipc_channel_connected());
 
   // Now that a connection has been established, we wait for the timeout.
   base::Time start_time(base::Time::NowFromSystemTime());
   WaitForOperationComplete();
   base::TimeDelta elapsed_time = base::Time::NowFromSystemTime() - start_time;
 
   ASSERT_NEAR(elapsed_time.InMilliseconds(), kInitialConnectTimeoutMs,
               kConnectionTimeoutErrorDeltaMs);
 }
 
 TEST_F(SecurityKeyIpcServerTest, SecurityKeyResponseTimeout) {
   // Create a channel, connect to it via IPC, and issue a request, but do
   // not send a response.  This simulates a client-side timeout.
   base::TimeDelta request_timeout(base::TimeDelta::FromMilliseconds(50));
   mojo::edk::NamedPlatformHandle channel_handle(GetUniqueTestChannelName());
   ASSERT_TRUE(
       security_key_ipc_server_->CreateChannel(channel_handle, request_timeout));
 
   // Create a fake client and connect to the IPC server channel.
   FakeSecurityKeyIpcClient fake_ipc_client(base::Bind(
       &SecurityKeyIpcServerTest::OperationComplete, base::Unretained(this)));
   ASSERT_TRUE(fake_ipc_client.ConnectViaIpc(channel_handle));
   WaitForOperationComplete();
 
+  ASSERT_FALSE(fake_ipc_client.invalid_session_error());
+  ASSERT_TRUE(fake_ipc_client.connection_ready());
   ASSERT_TRUE(fake_ipc_client.ipc_channel_connected());
 
   // Now that a connection has been established, we issue a request and
   // then wait for the timeout.
   std::string request_data("I can haz Auth?");
   fake_ipc_client.SendSecurityKeyRequestViaIpc(request_data);
   WaitForOperationComplete();
 
   // Leave the request hanging until it times out...
   base::Time start_time(base::Time::NowFromSystemTime());
@@ skipping 12 matching lines @@
   mojo::edk::NamedPlatformHandle channel_handle(GetUniqueTestChannelName());
   ASSERT_TRUE(
       security_key_ipc_server_->CreateChannel(channel_handle, request_timeout));
 
   // Create a fake client and connect to the IPC server channel.
   FakeSecurityKeyIpcClient fake_ipc_client(base::Bind(
       &SecurityKeyIpcServerTest::OperationComplete, base::Unretained(this)));
   ASSERT_TRUE(fake_ipc_client.ConnectViaIpc(channel_handle));
   WaitForOperationComplete();
 
+  ASSERT_FALSE(fake_ipc_client.invalid_session_error());
+  ASSERT_TRUE(fake_ipc_client.connection_ready());
   ASSERT_TRUE(fake_ipc_client.ipc_channel_connected());
 
   // Issue a request.
   std::string request_data("Auth me yo!");
   fake_ipc_client.SendSecurityKeyRequestViaIpc(request_data);
   WaitForOperationComplete();
 
   // Send a response from the IPC server to the IPC client.
   std::string response_data("OK, the secret code is 1-2-3-4-5");
   ASSERT_TRUE(security_key_ipc_server_->SendResponse(response_data));
@@ skipping 28 matching lines @@
   }
   // The mojo system posts tasks as part of its cleanup, so run them all.
   base::RunLoop().RunUntilIdle();
 
   // Create a fake client and connect to the IPC server channel.
   FakeSecurityKeyIpcClient fake_ipc_client(base::Bind(
       &SecurityKeyIpcServerTest::OperationComplete, base::Unretained(this)));
   ASSERT_TRUE(fake_ipc_client.ConnectViaIpc(channel_handle));
   WaitForOperationComplete();
 
+  ASSERT_FALSE(fake_ipc_client.invalid_session_error());
+  ASSERT_TRUE(fake_ipc_client.connection_ready());
   ASSERT_TRUE(fake_ipc_client.ipc_channel_connected());
 
   // Send a request from the IPC client to the IPC server.
   std::string request_data("Blergh!");
   fake_ipc_client.SendSecurityKeyRequestViaIpc(request_data);
   WaitForOperationComplete();
 
   // Verify the request was received.
   ASSERT_EQ(kTestConnectionId, last_connection_id_received_);
   ASSERT_EQ(request_data, last_message_received_);
@@ skipping 22 matching lines @@
 
   // Create a fake client and attempt to connect to the IPC server channel.
   FakeSecurityKeyIpcClient fake_ipc_client(base::Bind(
       &SecurityKeyIpcServerTest::OperationComplete, base::Unretained(this)));
   ASSERT_TRUE(fake_ipc_client.ConnectViaIpc(channel_handle));
   WaitForOperationComplete();
   WaitForOperationComplete();
   WaitForOperationComplete();
 
   // Verify the connection failed.
+  ASSERT_TRUE(fake_ipc_client.invalid_session_error());
+  ASSERT_FALSE(fake_ipc_client.connection_ready());
   ASSERT_FALSE(fake_ipc_client.ipc_channel_connected());
 }
 #endif  // defined(OS_WIN)
 
 }  // namespace remoting