Fix Process.runSync error handling.

Fix Process.runSync error handling.

Now, failing to allocate a buffer for stderr or stdout will generate
an ENOMEM OSError exception.

Also previously, read() returning an error would cause buffers for
stderr and stdout to leak. After this change, they'll be reclaimed.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/2b482617640234f10a0a1531156c778819bac025

[zra, 2016-12-20 21:09:01]

zra@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-12-20 23:42:55]

lgtm

https://codereview.chromium.org/2596543002/diff/40001/runtime/bin/process.h
File runtime/bin/process.h (right):

https://codereview.chromium.org/2596543002/diff/40001/runtime/bin/process.h#n...
runtime/bin/process.h:267: if (!node->Valid()) {
if ((node == NULL) || !node->Valid()) {

[zra, 2016-12-21 17:10:09]

https://codereview.chromium.org/2596543002/diff/40001/runtime/bin/process.h
File runtime/bin/process.h (right):

https://codereview.chromium.org/2596543002/diff/40001/runtime/bin/process.h#n...
runtime/bin/process.h:267: if (!node->Valid()) {
On 2016/12/20 23:42:55, siva wrote:
> if ((node == NULL) || !node->Valid()) {

Done.

[zra, 2016-12-21 17:10:45]

Description was changed from

==========
Fix Process.runSync error handling.

Now, failing to allocate a buffer for stderr or stdout will generate
an ENOMEM OSError exception.

Also previously, read() returning an error would cause buffers for
stderr and stdout to leak. After this change, they'll be reclaimed.
==========

to

==========
Fix Process.runSync error handling.

Now, failing to allocate a buffer for stderr or stdout will generate
an ENOMEM OSError exception.

Also previously, read() returning an error would cause buffers for
stderr and stdout to leak. After this change, they'll be reclaimed.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2b482617640234f10a0a1531156c778819bac025
==========

[zra, 2016-12-21 17:10:46]

Committed patchset #4 (id:60001) manually as
2b482617640234f10a0a1531156c778819bac025 (presubmit successful).