Issue 25965002: [Android Buildbot] Revert forking in adb_logcat_monitor.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25965002: [Android Buildbot] Revert forking in adb_logcat_monitor.py. (Closed)

Created:
7 years, 2 months ago by Siva Chandra

Modified:
7 years, 2 months ago

Reviewers:
navabi1, Isaac (away)

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android Buildbot] Revert forking in adb_logcat_monitor.py. This essentially reverts the changes made in https://codereview.chromium.org/24456002/ as they were found not to be useful. NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227084

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -10 lines)			Patch
	M	build/android/adb_logcat_monitor.py	View		1 chunk	+0 lines, -9 lines	0 comments	Download
	M	build/android/buildbot/bb_device_steps.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Siva Chandra

On 2013/10/04 01:37:09, Siva Chandra wrote: This is based on the suggestion made here (https://codereview.chromium.org/25679007/) ...

7 years, 2 months ago (2013-10-04 01:37:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/25965002/1

7 years, 2 months ago (2013-10-04 16:24:39 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/25965002/1

7 years, 2 months ago (2013-10-04 20:50:29 UTC) #5

Message was sent while issue was closed.

Change committed as 227084

Expand Messages | Collapse Messages