Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: components/crash/content/app/fallback_crash_handler_win.h

Issue 2596463002: A simple, practically zero cost fallback crash handler for Crashpad handler process. (Closed)
Patch Set: Tweak comments for moar better confusion-less reading. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
scottmg 2017/01/06 18:29:04 2017
Sigurður Ásgeirsson 2017/01/06 20:59:11 Done.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef COMPONENTS_CRASH_CONTENT_APP_FALLBACK_CRASH_HANDLER_WIN_H_
6 #define COMPONENTS_CRASH_CONTENT_APP_FALLBACK_CRASH_HANDLER_WIN_H_
7
8 #include "base/command_line.h"
9 #include "base/files/file_path.h"
10 #include "base/process/process.h"
11 #include "base/threading/platform_thread.h"
12
13 #include <windows.h>
scottmg 2017/01/06 18:29:04 <> before ""
Sigurður Ásgeirsson 2017/01/06 20:59:11 Done.
14
15 namespace crash_reporter {
16
17 // In the fallback crash handler, this invokes the system crash machinery
18 // (MinidumpWriteDump) to generate the crash report, then adds the report to
scottmg 2017/01/06 18:29:04 MiniDumpWriteDump
Sigurður Ásgeirsson 2017/01/06 20:59:11 Done.
19 // the Crashpad database for upload.
20 // TODO(siggi):
21 class FallbackCrashHandler {
22 public:
23 FallbackCrashHandler();
24 ~FallbackCrashHandler();
25
26 bool ParseCommandLine(base::CommandLine* cmd_line);
27 bool GenerateCrashDump();
28
29 private:
30 base::Process process_;
31 base::PlatformThreadId thread_id_;
32 // This pointer is in the address space of process_, not our own.
33 EXCEPTION_POINTERS* exc_ptrs_;
34 base::FilePath database_dir_;
35 };
36
37 } // namespace crash_reporter
38
39 #endif // COMPONENTS_CRASH_CONTENT_APP_FALLBACK_CRASH_HANDLER_WIN_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698