Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: ui/login/account_picker/screen_account_picker.js

Issue 2596423002: Account Picker: fix window resize. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/login/account_picker/screen_account_picker.js
diff --git a/ui/login/account_picker/screen_account_picker.js b/ui/login/account_picker/screen_account_picker.js
index 7cac00bc3a4131a61cced2d65def37864f3e96ef..eb9572c3c2ffcb79048fa15040919d642729c638 100644
--- a/ui/login/account_picker/screen_account_picker.js
+++ b/ui/login/account_picker/screen_account_picker.js
@@ -225,8 +225,10 @@ login.createScreen('AccountPickerScreen', 'account-picker', function() {
bubble.style.visibility = 'hidden';
bubble.hidden = false;
// Now we need the bubble to have the new content before calculating
- // size.
- bubble.replaceContent(error);
+ // size. Undefined |error| == reuse old content.
+ if (error !== undefined)
+ bubble.replaceContent(error);
+
// Get bubble size.
var bubbleOffsetHeight = parseInt(bubble.offsetHeight);
var bubbleOffsetWidth = parseInt(bubble.offsetWidth);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698