In skimage, copy to 8888 if encoding fails.

In skimage, copy to 8888 if encoding fails.

When writing the bitmap for visual comparison, rather than special
casing A8, depend on the fact that the encoder will fail, and try
copying to 8888 and encoding that if so.

R=reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=11633

[reed1, 2013-10-07 13:59:40]

lgtm w/ question about checking if we're already 8888 when we failed.

https://codereview.chromium.org/25964003/diff/1/tools/skimage_main.cpp
File tools/skimage_main.cpp (right):

https://codereview.chromium.org/25964003/diff/1/tools/skimage_main.cpp#newcod...
tools/skimage_main.cpp:118: SkBitmap bm8888;
Should we first check that we're not already 8888?

[scroggo, 2013-10-07 16:55:57]

https://codereview.chromium.org/25964003/diff/1/tools/skimage_main.cpp
File tools/skimage_main.cpp (right):

https://codereview.chromium.org/25964003/diff/1/tools/skimage_main.cpp#newcod...
tools/skimage_main.cpp:118: SkBitmap bm8888;
On 2013/10/07 13:59:40, reed1 wrote:
> Should we first check that we're not already 8888?

Done.

[scroggo, 2013-10-07 16:56:04]

Committed patchset #2 manually as r11633 (presubmit successful).