Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1350)

Unified Diff: docs/clang_tool_refactoring.md

Issue 2596383002: Update Windows-specific docs for the clang rewriting tool. (Closed)
Patch Set: windows-clang-tool: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/clang_tool_refactoring.md
diff --git a/docs/clang_tool_refactoring.md b/docs/clang_tool_refactoring.md
index 6e22a1ba50fa534e6d42dc8e1772c971163730e5..3226f05cd277345fc851bbdbfc00f7c0f6be1354 100644
--- a/docs/clang_tool_refactoring.md
+++ b/docs/clang_tool_refactoring.md
@@ -22,7 +22,6 @@ the tool once in each build config with code that needs to be updated.
Other minor issues:
* Requires a git checkout.
-* Requires [some hacks to run on Windows](https://codereview.chromium.org/718873004).
## Prerequisites
@@ -117,7 +116,15 @@ First, build all Chromium targets to avoid failures due to missing dependencies
that are generated as part of the build:
```shell
-ninja -C out/Debug
+ninja -C out/Debug # For non-Windows
+ninja -d keeprsp -C out/Debug # For Windows
+```
+
+On Windows, generate the compile DB first, and after making any source changes.
+Then omit the `--generate-compdb` in later steps.
+
+```shell
+tools/clang/scripts/generate_win_compdb.py
dcheng 2016/12/22 21:43:03 Nit: I think this takes an optional path to the bu
```
Then run the actual tool:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698