Chromium Code Reviews| Index: docs/clang_tool_refactoring.md |
| diff --git a/docs/clang_tool_refactoring.md b/docs/clang_tool_refactoring.md |
| index 6e22a1ba50fa534e6d42dc8e1772c971163730e5..3e77a665229deaca4b72b070ce4450cbca7b46f0 100644 |
| --- a/docs/clang_tool_refactoring.md |
| +++ b/docs/clang_tool_refactoring.md |
| @@ -22,7 +22,6 @@ the tool once in each build config with code that needs to be updated. |
| Other minor issues: |
| * Requires a git checkout. |
| -* Requires [some hacks to run on Windows](https://codereview.chromium.org/718873004). |
| ## Prerequisites |
| @@ -117,7 +116,8 @@ First, build all Chromium targets to avoid failures due to missing dependencies |
| that are generated as part of the build: |
| ```shell |
| -ninja -C out/Debug |
| +ninja -C out/Debug # For non-Windows |
| +ninja -d keeprsp -C out/Debug # For Windows |
| ``` |
| Then run the actual tool: |
| @@ -129,7 +129,9 @@ tools/clang/scripts/run_tool.py <toolname> \ |
| ``` |
| `--generate-compdb` can be omitted if the compile DB was already generated and |
| -the list of build flags and source files has not changed since generation. |
| +the list of build flags and source files has not changed since generation. NOTE: |
| +On windows to avoid this flag, you must also run the |
|
dcheng
2016/12/22 21:31:46
Nit:
NOTE: On Windows, use generate_win_compdb.py
|
| +`tools/clang/scripts/generate_win_compdb.py` script after generating the compdb. |
| `<path 1>`, `<path 2>`, etc are optional arguments to filter the files to run |
| the tool across. This is helpful when sharding global refactorings into smaller |