Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1421)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 2596303002: Fix an issue with not clearing |selected_text_| when text selection range is empty (Mac) (Closed)
Patch Set: Added a unit test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index d7c05d394688908451d1dc31bd77d54eb49d3238..4f9fa204a0a5f8620f68621df1c634d809d0259b 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -1011,8 +1011,9 @@ void RenderWidgetHostViewMac::OnTextSelectionChanged(
GetTextInputManager()->GetTextSelection(focused_view);
base::string16 text;
- if (selection->GetSelectedText(&text))
- selected_text_ = base::UTF16ToUTF8(text);
+ if (!selection->GetSelectedText(&text))
+ return;
+ selected_text_ = base::UTF16ToUTF8(text);
[cocoa_view_ setSelectedRange:selection->range.ToNSRange()];
// Updates markedRange when there is no marked text so that retrieving

Powered by Google App Engine
This is Rietveld 408576698