Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Unified Diff: content/browser/renderer_host/text_input_manager.cc

Issue 2596303002: Fix an issue with not clearing |selected_text_| when text selection range is empty (Mac) (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/text_input_manager.cc
diff --git a/content/browser/renderer_host/text_input_manager.cc b/content/browser/renderer_host/text_input_manager.cc
index 16897f88438e018a4733f8098d6514b92e29cb35..dc7e1b6b6bfa6c213cb13ebc711a58a91cecca23 100644
--- a/content/browser/renderer_host/text_input_manager.cc
+++ b/content/browser/renderer_host/text_input_manager.cc
@@ -329,14 +329,13 @@ TextInputManager::TextSelection::~TextSelection() {}
bool TextInputManager::TextSelection::GetSelectedText(
base::string16* selected_text) const {
if (text.empty() || range.is_empty())
- return false;
+ return true;
size_t pos = range.GetMin() - offset;
size_t n = range.length();
if (pos + n > text.length()) {
EhsanK 2016/12/22 20:06:22 Before, we used to DCHECK on this so return false
LOG(WARNING) << "The text can not fully cover range (selection's end point "
"exceeds text length).";
- return false;
}
if (pos >= text.length()) {

Powered by Google App Engine
This is Rietveld 408576698