Fix an issue with not clearing |selected_text_| when text selection range is empty (Mac)

content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_mac.h"
 
 #include <Cocoa/Cocoa.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <tuple>
@@ skipping 287 matching lines @@
     view->TextInputStateChanged(state);
   }
 
  private:
   // This class isn't derived from PlatformTest.
   base::mac::ScopedNSAutoreleasePool pool_;
 
   RenderWidgetHostView* old_rwhv_;
 
  protected:
+  std::string selected_text() const { return rwhv_mac_->selected_text_; }
+
   RenderWidgetHostViewMac* rwhv_mac_;
   base::scoped_nsobject<RenderWidgetHostViewCocoa> rwhv_cocoa_;
 
  private:

[EhsanK, 2016/12/22 20:06:23]

Weird formatting here with private->protected->private and also some spacing
between methods are wrong.

I can file this as a separate CL TBR if that sounds OK.

[Avi (use Gerrit), 2016/12/22 20:11:56]

Don't TBR, but please do send a followup CL to me to clean it up.

   DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewMacTest);
 };
 
 TEST_F(RenderWidgetHostViewMacTest, Basic) {
 }
 
 TEST_F(RenderWidgetHostViewMacTest, AcceptsFirstResponder) {
   // The RWHVCocoa should normally accept first responder status.
   EXPECT_TRUE([rwhv_cocoa_.get() acceptsFirstResponder]);
 }
@@ skipping 999 matching lines @@
   // Send an initial wheel event for scrolling by 3 lines.
   // Verify that Event.Latency.OS.MOUSE_WHEEL histogram is computed properly.
   NSEvent* wheelEvent = MockScrollWheelEventWithPhase(@selector(phaseBegan),3);
   [view->cocoa_view() scrollWheel:wheelEvent];
   histogram_tester.ExpectTotalCount("Event.Latency.OS.MOUSE_WHEEL", 1);
 
   // Clean up.
   host->ShutdownAndDestroyWidget(true);
 }
 
+// This test verifies that |selected_text_| is updated accordingly with
+// different variations of RWHVMac::SelectChanged updates.
+TEST_F(RenderWidgetHostViewMacTest, SelectedText) {
+  base::string16 sample_text;
+  base::UTF8ToUTF16("hello world!", 12, &sample_text);
+  gfx::Range range(6, 11);
+
+  // Send a valid selection for the word 'World'.
+  rwhv_mac_->SelectionChanged(sample_text, 0U, range);
+  EXPECT_EQ("world", selected_text());
+
+  // Make the range cover some of the text and extend more.
+  range.set_end(100);
+  rwhv_mac_->SelectionChanged(sample_text, 0U, range);
+  EXPECT_EQ("world!", selected_text());
+
+  // Finally, send an empty range. This should clear the selected text.
+  range.set_start(100);
+  rwhv_mac_->SelectionChanged(sample_text, 0U, range);
+  EXPECT_EQ("", selected_text());
+}
+
 // This class is used for IME-related unit tests which verify correctness of IME
 // for pages with multiple RWHVs.
 class InputMethodMacTest : public RenderWidgetHostViewMacTest {
  public:
   InputMethodMacTest() {}
   ~InputMethodMacTest() override {}
   void SetUp() override {
     RenderWidgetHostViewMacTest::SetUp();
 
     // Initializing a child frame's view.
@@ skipping 267 matching lines @@
   // Verify that this IPC is asking for no monitoring or immediate updates.
   InputMsg_RequestCompositionUpdate::Read(composition_request_msg_for_child,
                                           &child_msg_params);
   is_child_msg_for_immediate_request = std::get<0>(child_msg_params);
   is_child_msg_for_monitor_request = std::get<1>(child_msg_params);
   EXPECT_FALSE(is_child_msg_for_immediate_request);
   EXPECT_FALSE(is_child_msg_for_monitor_request);
 }
 
 }  // namespace content