Use stricter comment-detecting heuristics

Use stricter comment-detecting heuristics

This decreases false positive of comment detection.

BUG=676638
R=mdjones@chromium.org

Committed: ac91168f2936bb931fb187586ffb14ccea458b44

[wychen, 2016-12-23 05:18:27]

wychen@chromium.org changed reviewers:
+ mdjones@chromium.org

[wychen, 2016-12-23 05:18:27]

PTAL

[mdjones, 2017-01-04 14:29:21]

lgtm % suggestion

https://codereview.chromium.org/2596283004/diff/1/java/org/chromium/distiller...
File java/org/chromium/distiller/webdocument/ElementAction.java (right):

https://codereview.chromium.org/2596283004/diff/1/java/org/chromium/distiller...
java/org/chromium/distiller/webdocument/ElementAction.java:23: private static
final int MAX_CLASS_COUNT = 2;
nit: the way this is used seems to be as a minimum number, can we change this to
MIN_CLASS_COUNT?

[wychen, 2017-01-04 14:37:51]

https://codereview.chromium.org/2596283004/diff/1/java/org/chromium/distiller...
File java/org/chromium/distiller/webdocument/ElementAction.java (right):

https://codereview.chromium.org/2596283004/diff/1/java/org/chromium/distiller...
java/org/chromium/distiller/webdocument/ElementAction.java:23: private static
final int MAX_CLASS_COUNT = 2;
On 2017/01/04 14:29:21, mdjones wrote:
> nit: the way this is used seems to be as a minimum number, can we change this
to
> MIN_CLASS_COUNT?

What do you mean?
This constant is the largest allowed number of class names for this heuristic to
be enabled, so sounds like max more than min, right?

[mdjones, 2017-01-04 15:14:33]

still lgtm

https://codereview.chromium.org/2596283004/diff/1/java/org/chromium/distiller...
File java/org/chromium/distiller/webdocument/ElementAction.java (right):

https://codereview.chromium.org/2596283004/diff/1/java/org/chromium/distiller...
java/org/chromium/distiller/webdocument/ElementAction.java:23: private static
final int MAX_CLASS_COUNT = 2;
On 2017/01/04 14:37:51, wychen wrote:
> On 2017/01/04 14:29:21, mdjones wrote:
> > nit: the way this is used seems to be as a minimum number, can we change
this
> to
> > MIN_CLASS_COUNT?
> 
> What do you mean?
> This constant is the largest allowed number of class names for this heuristic
to
> be enabled, so sounds like max more than min, right?

Ah, I was looking at it from: "if class count doesn't meet this number, it's not
content".

[wychen, 2017-01-09 12:39:51]

Description was changed from

==========
Use stricter comment-detecting heuristics

This decreases false positive of comment detection.

BUG=676638
==========

to

==========
Use stricter comment-detecting heuristics

This decreases false positive of comment detection.

BUG=676638
R=mdjones@chromium.org

Committed: ac91168f2936bb931fb187586ffb14ccea458b44
==========

[wychen, 2017-01-09 12:39:52]

Committed patchset #1 (id:1) manually as
ac91168f2936bb931fb187586ffb14ccea458b44 (presubmit successful).