Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 259623002: Remove FromDict from dorameo, indexeddb_perf, jsgamebench, kraken, octane, peacekeeper (Closed)

Created:
6 years, 8 months ago by nednguyen
Modified:
6 years, 7 months ago
Reviewers:
dtu, tonyg, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove FromDict from dorameo, indexeddb_perf, jsgamebench, kraken, octane, peacekeeper NOTRY=true BUG=239179 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266889

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -47 lines) Patch
M tools/perf/benchmarks/dromaeo.py View 1 chunk +4 lines, -5 lines 0 comments Download
M tools/perf/benchmarks/indexeddb_perf.py View 1 chunk +3 lines, -5 lines 0 comments Download
M tools/perf/benchmarks/jsgamebench.py View 1 1 chunk +5 lines, -6 lines 0 comments Download
M tools/perf/benchmarks/kraken.py View 1 chunk +6 lines, -6 lines 0 comments Download
M tools/perf/benchmarks/octane.py View 1 chunk +7 lines, -9 lines 0 comments Download
M tools/perf/benchmarks/peacekeeper.py View 2 chunks +9 lines, -16 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
nednguyen
6 years, 7 months ago (2014-04-28 21:00:47 UTC) #1
dtu
lgtm
6 years, 7 months ago (2014-04-28 21:38:53 UTC) #2
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-04-28 21:39:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/259623002/1
6 years, 7 months ago (2014-04-28 21:41:00 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 21:44:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 7 months ago (2014-04-28 21:44:53 UTC) #6
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-04-28 21:45:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/259623002/1
6 years, 7 months ago (2014-04-28 21:47:29 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 22:34:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-28 22:34:17 UTC) #10
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-04-28 22:44:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/259623002/1
6 years, 7 months ago (2014-04-28 22:45:34 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 23:31:46 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-28 23:31:46 UTC) #14
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-04-29 03:57:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/259623002/1
6 years, 7 months ago (2014-04-29 03:58:20 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 04:39:44 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-29 04:39:45 UTC) #18
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-04-29 04:48:06 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/259623002/20001
6 years, 7 months ago (2014-04-29 04:48:40 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 05:28:25 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-29 05:28:26 UTC) #22
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-04-29 12:55:04 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/259623002/20001
6 years, 7 months ago (2014-04-29 12:55:09 UTC) #24
nednguyen
The CQ bit was unchecked by nednguyen@google.com
6 years, 7 months ago (2014-04-29 12:55:20 UTC) #25
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-04-29 14:59:32 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/259623002/20001
6 years, 7 months ago (2014-04-29 14:59:55 UTC) #27
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 15:00:43 UTC) #28
Message was sent while issue was closed. 
Change committed as 266889

Powered by Google App Engine
This is Rietveld 408576698