third_party/WebKit/public/web/WebViewClient.h - Issue 2596193002: Clean up names and remove unnecessary parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/WebViewClient.h

Issue 2596193002: Clean up names and remove unnecessary parameter (Closed)

Patch Set: change show_ime to show_virtual_keyboard in the renderer Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/public/web/WebViewClient.h

diff --git a/third_party/WebKit/public/web/WebViewClient.h b/third_party/WebKit/public/web/WebViewClient.h

index af3fe7c18514915fa668e2101eac7a937cc7fbe9..f9d15ae4dcd2fa133a898e0afcc07da4c57f35d7 100644

--- a/third_party/WebKit/public/web/WebViewClient.h

+++ b/third_party/WebKit/public/web/WebViewClient.h

@@ -276,7 +276,7 @@ class WebViewClient : protected WebWidgetClient {

void resetInputMethod() override {}

WebScreenInfo screenInfo() override { return WebScreenInfo(); }

void setTouchAction(WebTouchAction touchAction) override {}

- void showImeIfNeeded() override {}

+ void showVirtualKeyboard() override {}

void showUnhandledTapUIIfNeeded(const WebPoint& tappedPosition,

const WebNode& tappedNode,

bool pageChanged) override {}