third_party/WebKit/Source/web/ChromeClientImpl.h - Issue 2596193002: Clean up names and remove unnecessary parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.h

Issue 2596193002: Clean up names and remove unnecessary parameter (Closed)

Patch Set: change show_ime to show_virtual_keyboard in the renderer Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ChromeClientImpl.h

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.h b/third_party/WebKit/Source/web/ChromeClientImpl.h

index a031178fd228e8b935bea53a4f102ea478b46a49..9d0948d9df3692b29a661a451f6d036602c8aa30 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.h

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.h

@@ -199,7 +199,7 @@ class WEB_EXPORT ChromeClientImpl final : public ChromeClient {

void didCancelCompositionOnSelectionChange() override;

void resetInputMethod() override;

- void showImeIfNeeded() override;

+ void showVirtualKeyboard() override;

void registerViewportLayers() const override;