content/renderer/render_view_impl.h - Issue 2596193002: Clean up names and remove unnecessary parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 2596193002: Clean up names and remove unnecessary parameter (Closed)

Patch Set: change show_ime to show_virtual_keyboard in the renderer Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index 69ce1ae1e31338c1551e8d6eb8e24c6428e819d1..2b6b0293a1a574b03f8d67f77676b5bf452cf7a5 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -283,7 +283,7 @@ class CONTENT_EXPORT RenderViewImpl

void setToolTipText(const blink::WebString&,

blink::WebTextDirection hint) override;

void setTouchAction(blink::WebTouchAction touchAction) override;

- void showImeIfNeeded() override;

+ void showVirtualKeyboard() override;

void showUnhandledTapUIIfNeeded(const blink::WebPoint& tappedPosition,

const blink::WebNode& tappedNode,

bool pageChanged) override;