content/renderer/render_view_impl.cc - Issue 2596193002: Clean up names and remove unnecessary parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 2596193002: Clean up names and remove unnecessary parameter (Closed)

Patch Set: change show_ime to show_virtual_keyboard in the renderer Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index b0cbd2613e87a22be9eae10bab53f4323cf79126..860b6f20c6122bd7115684c7eb526050764ba730 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -1903,8 +1903,8 @@ void RenderViewImpl::setTouchAction(blink::WebTouchAction touchAction) {

RenderWidget::setTouchAction(touchAction);

}

-void RenderViewImpl::showImeIfNeeded() {

- RenderWidget::showImeIfNeeded();

+void RenderViewImpl::showVirtualKeyboard() {

+ RenderWidget::showVirtualKeyboard();

}

void RenderViewImpl::showUnhandledTapUIIfNeeded(