content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 2596193002: Clean up names and remove unnecessary parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2596193002: Clean up names and remove unnecessary parameter (Closed)

Patch Set: change parameter name, pass parameter directly Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/view_messages.h ('K') | « content/common/view_messages.h ('k') | content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java » ('j') | content/renderer/input/render_widget_input_handler_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index d51e32f303eb6f4bf2248e4e6e07fc28bd275303..6e21f96e36b361c53ac9cb54430bbd61455cce32 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -1899,7 +1899,7 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa

private void updateImeAdapter(long nativeImeAdapterAndroid, int textInputType,

int textInputFlags, int textInputMode, String text, int selectionStart,

int selectionEnd, int compositionStart, int compositionEnd, boolean showImeIfNeeded,

- boolean isNonImeChange) {

+ boolean replyToRequest) {

try {

TraceEvent.begin("ContentViewCore.updateImeAdapter");

boolean focusedNodeEditable = (textInputType != TextInputType.NONE);

@@ -1909,7 +1909,7 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa

mImeAdapter.updateKeyboardVisibility(

textInputType, textInputFlags, textInputMode, showImeIfNeeded);

mImeAdapter.updateState(text, selectionStart, selectionEnd, compositionStart,

- compositionEnd, isNonImeChange);

+ compositionEnd, replyToRequest);

boolean editableToggled = (focusedNodeEditable != isFocusedNodeEditable());

mSelectionPopupController.updateSelectionState(focusedNodeEditable,