Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2596193002: Clean up names and remove unnecessary parameter (Closed)
Patch Set: use correct patch Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index c424e70f7b106477e6c5b59c00aa17763921813e..3441702df4c7fb80606537d73436d95033e591c6 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1305,8 +1305,7 @@ void RenderFrameImpl::PepperTextInputTypeChanged(
if (instance != focused_pepper_plugin_)
return;
- GetRenderWidget()->UpdateTextInputState(ShowIme::HIDE_IME,
- ChangeSource::FROM_NON_IME);
+ GetRenderWidget()->UpdateTextInputState(ShowIme::DO_NOT_SHOW);
FocusedNodeChangedForAccessibility(WebNode());
}
@@ -4002,8 +4001,7 @@ void RenderFrameImpl::didChangeSelection(bool is_empty_selection) {
// was changed, and SyncSelectionIfRequired may send SelectionChanged
// to notify the selection was changed. Focus change should be notified
// before selection change.
- GetRenderWidget()->UpdateTextInputState(ShowIme::HIDE_IME,
- ChangeSource::FROM_NON_IME);
+ GetRenderWidget()->UpdateTextInputState(ShowIme::DO_NOT_SHOW);
SyncSelectionIfRequired();
}
@@ -6713,8 +6711,7 @@ void RenderFrameImpl::PepperFocusChanged(PepperPluginInstanceImpl* instance,
GetRenderWidget()->set_focused_pepper_plugin(focused_pepper_plugin_);
- GetRenderWidget()->UpdateTextInputState(ShowIme::HIDE_IME,
- ChangeSource::FROM_NON_IME);
+ GetRenderWidget()->UpdateTextInputState(ShowIme::DO_NOT_SHOW);
GetRenderWidget()->UpdateSelectionBounds();
}

Powered by Google App Engine
This is Rietveld 408576698