Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2596193002: Clean up names and remove unnecessary parameter (Closed)
Patch Set: change show_ime to show_virtual_keyboard in the renderer Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 993 matching lines...) Expand 10 before | Expand all | Expand 10 after
1004 void ChromeClientImpl::didCancelCompositionOnSelectionChange() { 1004 void ChromeClientImpl::didCancelCompositionOnSelectionChange() {
1005 if (m_webView->client()) 1005 if (m_webView->client())
1006 m_webView->client()->didCancelCompositionOnSelectionChange(); 1006 m_webView->client()->didCancelCompositionOnSelectionChange();
1007 } 1007 }
1008 1008
1009 void ChromeClientImpl::resetInputMethod() { 1009 void ChromeClientImpl::resetInputMethod() {
1010 if (m_webView->client()) 1010 if (m_webView->client())
1011 m_webView->client()->resetInputMethod(); 1011 m_webView->client()->resetInputMethod();
1012 } 1012 }
1013 1013
1014 void ChromeClientImpl::showImeIfNeeded() { 1014 void ChromeClientImpl::showVirtualKeyboard() {
1015 if (m_webView->client()) 1015 if (m_webView->client())
1016 m_webView->client()->showImeIfNeeded(); 1016 m_webView->client()->showVirtualKeyboard();
1017 } 1017 }
1018 1018
1019 void ChromeClientImpl::showUnhandledTapUIIfNeeded( 1019 void ChromeClientImpl::showUnhandledTapUIIfNeeded(
1020 IntPoint tappedPositionInViewport, 1020 IntPoint tappedPositionInViewport,
1021 Node* tappedNode, 1021 Node* tappedNode,
1022 bool pageChanged) { 1022 bool pageChanged) {
1023 if (m_webView->client()) 1023 if (m_webView->client())
1024 m_webView->client()->showUnhandledTapUIIfNeeded( 1024 m_webView->client()->showUnhandledTapUIIfNeeded(
1025 WebPoint(tappedPositionInViewport), WebNode(tappedNode), pageChanged); 1025 WebPoint(tappedPositionInViewport), WebNode(tappedNode), pageChanged);
1026 } 1026 }
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
1153 PresentationController::provideTo(frame, client->presentationClient()); 1153 PresentationController::provideTo(frame, client->presentationClient());
1154 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) { 1154 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) {
1155 provideAudioOutputDeviceClientTo(frame, 1155 provideAudioOutputDeviceClientTo(frame,
1156 new AudioOutputDeviceClientImpl(frame)); 1156 new AudioOutputDeviceClientImpl(frame));
1157 } 1157 }
1158 if (RuntimeEnabledFeatures::installedAppEnabled()) 1158 if (RuntimeEnabledFeatures::installedAppEnabled())
1159 InstalledAppController::provideTo(frame, client->installedAppClient()); 1159 InstalledAppController::provideTo(frame, client->installedAppClient());
1160 } 1160 }
1161 1161
1162 } // namespace blink 1162 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698